Modify schema to include defaulting information.

chrome/browser/intents/default_web_intent_service.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_INTENTS_DEFAULT_WEB_INTENT_SERVICE_H_
+#define CHROME_BROWSER_INTENTS_DEFAULT_WEB_INTENT_SERVICE_H_
+
+#include <string>
+
+#include "base/string16.h"
+
+// Holds data related to a default settings for web intents service
+// selection. Holds data in a row in the web_intents_defaults table.
+// The key for the table is the |action|, |type|, and |url_prefix|.
+// These describe the action and type of the web intent for which the
+// default is set, and the url prefix (if any) of source pages for
+// which the default applies. The main actionable value is the URL
+// of the service or extension page handling the intent. The user_date

[groby-ooo-7-16, 2012/02/08 23:18:38]

nit: |user_date|, |suppression|

[Greg Billock, 2012/02/08 23:34:06]

Done.

+// and suppression fields are provided for more intricate post-fetch
+// decisions about whether to use a particular default service.
+struct DefaultWebIntentService {
+  string16 action;

[groby-ooo-7-16, 2012/02/08 23:18:38]

nit: Please document members.

[Greg Billock, 2012/02/08 23:34:06]

I put this in the struct comment. Given the multi-field key, I thought that was
clearer. Is something missing there that ought to be explained here?

[groby-ooo-7-16, 2012/02/08 23:48:07]

I'm not sure what exactly is stored e.g. in |user_date| and |suppression|. I
_assume_ it's a time_t when that became active. (Why not time_t, btw?)

And while I'm on types, url_prefix should probably be URLPattern, so we can just
MatchURL().

I'm also not sure about the distinction between |service_url| and
|extension_url|.

On 2012/02/08 23:34:06, Greg Billock wrote:

+  string16 type;
+  std::string url_prefix;
+  int user_date;
+  int suppression;
+  std::string service_url;
+  std::string extension_url;
+};
+
+#endif  // CHROME_BROWSER_INTENTS_DEFAULT_WEB_INTENT_SERVICE_H_