Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 9104010: Set CG clip to empty explicitly (Closed)

Created:
8 years, 10 months ago by _cary
Modified:
8 years, 10 months ago
Reviewers:
Stephen White
CC:
chromium-reviews
Visibility:
Public.

Description

Set CG clip to empty explicitly Skia draws Mac user elements by creating a CoreGraphics context that mirrors Skia's SkCanvas' context. CoreGraphics does not consider a newly created path to be empty. Explicitly set it to empty so the subsequent drawing is clipped out. BUG: 111642 TEST: http://jsfiddle.net/kenjibaheux/UN3Dt/3/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119962

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M skia/ext/skia_utils_mac.mm View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
_cary
8 years, 10 months ago (2012-01-30 16:44:12 UTC) #1
Stephen White
lgtm https://chromiumcodereview.appspot.com/9104010/diff/1/skia/ext/skia_utils_mac.mm File skia/ext/skia_utils_mac.mm (right): https://chromiumcodereview.appspot.com/9104010/diff/1/skia/ext/skia_utils_mac.mm#newcode338 skia/ext/skia_utils_mac.mm:338: /* CoreGraphics does not consider a newly created ...
8 years, 10 months ago (2012-01-31 19:44:45 UTC) #2
_cary
Fixed nit. On 2012/01/31 19:44:45, Stephen White wrote: > lgtm > > https://chromiumcodereview.appspot.com/9104010/diff/1/skia/ext/skia_utils_mac.mm > File ...
8 years, 10 months ago (2012-01-31 19:49:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caryclark@chromium.org/9104010/4001
8 years, 10 months ago (2012-01-31 19:51:30 UTC) #4
commit-bot: I haz the power
8 years, 10 months ago (2012-01-31 21:37:08 UTC) #5
Change committed as 119962

Powered by Google App Engine
This is Rietveld 408576698