Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 9104002: Add annotator tags for better debugging. More suppressions and other tweaks. (Closed)

Created:
8 years, 11 months ago by John Grabowski
Modified:
8 years, 11 months ago
Reviewers:
nyquist
CC:
chromium-reviews, Peter Beverloo
Visibility:
Public.

Description

Add annotator tags for better debugging. More suppressions and other tweaks. BUG=None TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117583

Patch Set 1 #

Total comments: 4

Patch Set 2 : tommy feedback #

Patch Set 3 : more feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -15 lines) Patch
M build/android/gtest_filter/base_unittests_disabled View 1 chunk +7 lines, -0 lines 0 comments Download
M build/android/gtest_filter/net_unittests_disabled View 1 chunk +4 lines, -1 line 0 comments Download
M build/android/run_tests.py View 1 2 7 chunks +28 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
John Grabowski
8 years, 11 months ago (2012-01-13 02:01:46 UTC) #1
nyquist
http://codereview.chromium.org/9104002/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/9104002/diff/1/build/android/run_tests.py#newcode223 build/android/run_tests.py:223: first_run: is this the first time we tried this ...
8 years, 11 months ago (2012-01-13 02:16:59 UTC) #2
John Grabowski
http://codereview.chromium.org/9104002/diff/1/build/android/run_tests.py File build/android/run_tests.py (right): http://codereview.chromium.org/9104002/diff/1/build/android/run_tests.py#newcode223 build/android/run_tests.py:223: first_run: is this the first time we tried this ...
8 years, 11 months ago (2012-01-13 02:20:10 UTC) #3
nyquist
8 years, 11 months ago (2012-01-13 02:31:15 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698