Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: net/base/net_log_event_type_list.h

Issue 9101011: [net/dns] Refactoring of job dispatch in HostResolverImpl in preparation for DnsTransactionFactory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed license header for the presubmit check.' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/host_resolver_impl_unittest.cc ('k') | net/base/net_log_source_type_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_log_event_type_list.h
diff --git a/net/base/net_log_event_type_list.h b/net/base/net_log_event_type_list.h
index 44f6f22bbf26a48445921100295fd301d65fb8cc..9a7e2088b10126c7a126a4d33a84fcb45bef6ffc 100644
--- a/net/base/net_log_event_type_list.h
+++ b/net/base/net_log_event_type_list.h
@@ -58,32 +58,46 @@ EVENT_TYPE(HOST_RESOLVER_IMPL)
// "net_error": <The net error code integer for the failure>,
// "os_error": <The exact error code integer that getaddrinfo() returned>,
// }
-
EVENT_TYPE(HOST_RESOLVER_IMPL_REQUEST)
// This event is logged when a request is handled by a cache entry.
EVENT_TYPE(HOST_RESOLVER_IMPL_CACHE_HIT)
-// This event means a request was queued/dequeued for subsequent job creation,
-// because there are already too many active HostResolverImpl::Jobs.
+// This event is created when a new HostResolverImpl::Job is about to be created
+// for a request.
+EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
+
+// The creation/completion of a HostResolverImpl::Job which is created for
+// Requests that cannot be resolved synchronously.
//
// The BEGIN phase contains the following parameters:
//
// {
-// "priority": <Priority of the queued request>,
+// "host": <Hostname associated with the request>,
+// "source_dependency": <Source id, if any, of what created the request>,
+// }
+//
+// On success, the END phase has these parameters:
+// {
+// "address_list": <The host name being resolved>,
+// }
+// If an error occurred, the END phase will contain these parameters:
+// {
+// "net_error": <The net error code integer for the failure>,
+// "os_error": <The exact error code integer that getaddrinfo() returned>,
// }
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_POOL_QUEUE)
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB)
-// This event is created when a new HostResolverImpl::Request is evicted from
-// JobPool without a Job being created, because the limit on number of queued
-// Requests was reached.
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_POOL_QUEUE_EVICTED)
+// This event is created when a HostResolverImpl::Job is evicted from
+// PriorityDispatch before it can start, because the limit on number of queued
+// Jobs was reached.
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_EVICTED)
-// This event is created when a new HostResolverImpl::Job is about to be created
-// for a request.
-EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
+// This event is created when a HostResolverImpl::Job is started by
+// PriorityDispatch.
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_STARTED)
-// This event is created when HostResolverImpl::Job is about to start a new
+// This event is created when HostResolverImpl::ProcJob is about to start a new
// attempt to resolve the host.
//
// The ATTEMPT_STARTED event has the parameters:
@@ -93,8 +107,8 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_JOB)
// }
EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_STARTED)
-// This event is created when HostResolverImpl::Job has finished resolving the
-// host.
+// This event is created when HostResolverImpl::ProcJob has finished resolving
+// the host.
//
// The ATTEMPT_FINISHED event has the parameters:
//
@@ -109,24 +123,52 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_STARTED)
EVENT_TYPE(HOST_RESOLVER_IMPL_ATTEMPT_FINISHED)
// This is logged for a request when it's attached to a
-// HostResolverImpl::Job. When this occurs without a preceding
+// HostResolverImpl::Job. When this occurs without a preceding
// HOST_RESOLVER_IMPL_CREATE_JOB entry, it means the request was attached to an
// existing HostResolverImpl::Job.
//
-// If the BoundNetLog used to create the event has a valid source id, the BEGIN
-// phase contains the following parameters:
+// The event contains the following parameters:
//
// {
// "source_dependency": <Source identifier for the attached Job>,
// }
+//
EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_ATTACH)
-// The creation/completion of a host resolve (DNS) job.
+// This event is logged for the job to which the request is attached.
+// In that case, the event contains the following parameters:
+//
+// {
+// "source_dependency": <Source identifier for the attached Request>,
+// "priority": <New priority of the job>,
+// }
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_REQUEST_ATTACH)
+
+// This is logged for a job when a request is cancelled and detached.
+//
+// The event contains the following parameters:
+//
+// {
+// "source_dependency": <Source identifier for the detached Request>,
+// "priority": <New priority of the job>,
+// }
+EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_REQUEST_DETACH)
+
+// Logged for a HostResolverImpl::Job when it creates a ProcTask.
+//
+// The event contains the following parameters:
+//
+// {
+// "source_dependency": <Source id of parent HostResolverImpl::Job>,
+// }
+EVENT_TYPE(HOST_RESOLVER_IMPL_CREATE_PROC_TASK)
+
+// The creation/completion of a HostResolverImpl::ProcTask to call getaddrinfo.
// The BEGIN phase contains the following parameters:
//
// {
-// "host": <Hostname associated with the request>,
-// "source_dependency": <Source id, if any, of what created the request>,
+// "hostname": <Hostname associated with the request>,
+// "source_dependency": <Source id of parent HostResolverImpl::Job>,
// }
//
// On success, the END phase has these parameters:
@@ -138,7 +180,7 @@ EVENT_TYPE(HOST_RESOLVER_IMPL_JOB_ATTACH)
// "net_error": <The net error code integer for the failure>,
// "os_error": <The exact error code integer that getaddrinfo() returned>,
// }
-EVENT_TYPE(HOST_RESOLVER_IMPL_JOB)
+EVENT_TYPE(HOST_RESOLVER_IMPL_PROC_TASK)
// ------------------------------------------------------------------------
// InitProxyResolver
« no previous file with comments | « net/base/host_resolver_impl_unittest.cc ('k') | net/base/net_log_source_type_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698