Factor more colors into NativeTheme.

Factor more colors into NativeTheme.


BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117245

[Emmanuel Saint-loubert-Bié, 2012-01-06 19:28:33]

Hi Ben,

More color re-factoring in Theme.

-- Emmanuel

[benrg, 2012-01-06 19:38:00]

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc
File ui/gfx/native_theme_aura.cc (right):

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc...
ui/gfx/native_theme_aura.cc:21: const SkColor kDefaultDialogBackgroundColor =
SkColorSetRGB(200, 200, 200);
Change kDefault* to kAura* or just k* since these are the platform colors (the
colors in NativeThemeBase were overridable defaults). Ditto in
native_theme_chromeos.cc.

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc...
ui/gfx/native_theme_aura.cc:37: SkColorSetRGB(0xDC, 0xE4, 0xFA);
These are the ChromeOS values. The !defined(OS_CHROMEOS) values in the original
code were kDefaultTextButtonEnabledColor, kDefaultTextButtonDisabledColor, and
SkColorSetRGB(246, 249, 253).

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.h
File ui/gfx/native_theme_aura.h (right):

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.h#...
ui/gfx/native_theme_aura.h:29: virtual SkColor GetSystemColor(ColorId color_id)
const OVERRIDE;
This is a NativeTheme override. (Ditto in native_theme_chromeos.h.)

[Emmanuel Saint-loubert-Bié, 2012-01-06 21:51:07]

Hi Ben (Goodger),

PTAL. Thanks,

-- Emmanuel

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc
File ui/gfx/native_theme_aura.cc (right):

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc...
ui/gfx/native_theme_aura.cc:21: const SkColor kDefaultDialogBackgroundColor =
SkColorSetRGB(200, 200, 200);
On 2012/01/06 19:38:01, benrg wrote:
> Change kDefault* to kAura* or just k* since these are the platform colors (the
> colors in NativeThemeBase were overridable defaults). Ditto in
> native_theme_chromeos.cc.

Done.

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.cc...
ui/gfx/native_theme_aura.cc:37: SkColorSetRGB(0xDC, 0xE4, 0xFA);
I hesitated and I think we should start with the chromeos ones values for Aura
(when undefined like in this case).

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.h
File ui/gfx/native_theme_aura.h (right):

http://codereview.chromium.org/9101004/diff/13001/ui/gfx/native_theme_aura.h#...
ui/gfx/native_theme_aura.h:29: virtual SkColor GetSystemColor(ColorId color_id)
const OVERRIDE;
On 2012/01/06 19:38:01, benrg wrote:
> This is a NativeTheme override. (Ditto in native_theme_chromeos.h.)

Done.

[Ben Goodger (Google), 2012-01-09 16:37:26]

lgtm

[commit-bot: I haz the power, 2012-01-09 17:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/9101004/9002

[commit-bot: I haz the power, 2012-01-09 18:21:29]

Try job failure for 9101004-9002 (retry) on win_rel for steps
"safe_browsing_tests, unit_tests, views_unittests, browser_tests, ui_tests".
It's a second try, previously, steps "safe_browsing_tests, unit_tests,
views_unittests, browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-01-11 17:35:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/saintlou@chromium.org/9101004/28003

[commit-bot: I haz the power, 2012-01-11 18:49:52]

Change committed as 117245