Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 9097008: WebSocket Pepper API: fix wrong return code on thunk (Closed)

Created:
8 years, 11 months ago by Takashi Toyoshima
Modified:
8 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

WebSocket Pepper API: fix wrong return code on thunk Some thunk functions returned PP_ERROR_BADRESOURCE for EnterResource failure though returning value is not int32_t error code. BUG=87310 TEST=ui_tests --gtest_filter='PPAPI*.WebSocket_*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ppapi/thunk/ppb_websocket_thunk.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Takashi Toyoshima
Hi, could you review this CL? It's a very small and trivial bug fix. Thanks
8 years, 11 months ago (2012-01-17 06:37:15 UTC) #1
piman
lgtm
8 years, 11 months ago (2012-01-17 17:36:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9097008/1
8 years, 11 months ago (2012-01-18 01:02:53 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-18 04:25:26 UTC) #4
Change committed as 118050

Powered by Google App Engine
This is Rietveld 408576698