Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: content/public/browser/web_ui_factory.h

Issue 9097005: Move WebUIFactory into content/public/browser and make it use WebContents instead of TabContents.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sync Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_ui_factory.h
===================================================================
--- content/public/browser/web_ui_factory.h (revision 116681)
+++ content/public/browser/web_ui_factory.h (working copy)
@@ -2,19 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_BROWSER_WEBUI_WEB_UI_FACTORY_H_
-#define CONTENT_BROWSER_WEBUI_WEB_UI_FACTORY_H_
+#ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_FACTORY_H_
+#define CONTENT_PUBLIC_BROWSER_WEB_UI_FACTORY_H_
#pragma once
#include "content/browser/webui/web_ui.h"
#include "content/common/content_export.h"
-class TabContents;
class GURL;
namespace content {
class BrowserContext;
+class WebContents;
// Interface for an object which controls which URLs are considered WebUI URLs
// and creates WebUI instances for given URLs.
@@ -22,21 +22,21 @@
public:
// Returns a WebUI instance for the given URL, or NULL if the URL doesn't
// correspond to a WebUI.
- virtual WebUI* CreateWebUIForURL(TabContents* source,
+ virtual WebUI* CreateWebUIForURL(WebContents* source,
const GURL& url) const = 0;
// Gets the WebUI type for the given URL. This will return kNoWebUI if the
// corresponding call to CreateWebUIForURL would fail, or something non-NULL
// if CreateWebUIForURL would succeed.
- virtual WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,
+ virtual WebUI::TypeID GetWebUIType(BrowserContext* browser_context,
const GURL& url) const = 0;
// Shorthand for the above, but returns a simple yes/no.
- virtual bool UseWebUIForURL(content::BrowserContext* browser_context,
+ virtual bool UseWebUIForURL(BrowserContext* browser_context,
const GURL& url) const = 0;
// Returns true for the subset of WebUIs that actually need WebUI bindings.
- virtual bool UseWebUIBindingsForURL(content::BrowserContext* browser_context,
+ virtual bool UseWebUIBindingsForURL(BrowserContext* browser_context,
const GURL& url) const = 0;
// Returns true if the url has a scheme for WebUI. This differs from the above
@@ -47,17 +47,12 @@
// Returns true if the given URL can be loaded by Web UI system. This allows
// URLs with WebUI types (as above) and also URLs that can be loaded by
// normal tabs such as javascript: URLs or about:hang.
- virtual bool IsURLAcceptableForWebUI(content::BrowserContext* browser_context,
+ virtual bool IsURLAcceptableForWebUI(BrowserContext* browser_context,
const GURL& url) const = 0;
virtual ~WebUIFactory() {}
-
- // Helper function to streamline retrieval of the current WebUIFactory. Only
- // to be used in content/. Guaranteed to return non-NULL.
- static WebUIFactory* Get();
};
-
} // namespace content
-#endif // CONTENT_BROWSER_WEBUI_WEB_UI_FACTORY_H_
+#endif // CONTENT_PUBLIC_BROWSER_WEB_UI_FACTORY_H_
« no previous file with comments | « content/content_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698