Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 9097005: Move WebUIFactory into content/public/browser and make it use WebContents instead of TabContents.... (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move WebUIFactory into content/public/browser and make it use WebContents instead of TabContents. Update all callers accordingly. I also got rid of WebUIFactory::Get. It was only called in a few places, and as part of the Content API we want to avoid cc files in the public directory. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116795

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -137 lines) Patch
M chrome/browser/extensions/extension_web_ui.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 4 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/test_chrome_web_ui_factory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/test_chrome_web_ui_factory.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browsing_instance.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/webui/empty_web_ui_factory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/webui/empty_web_ui_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/browser/webui/web_ui_factory.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
D content/browser/webui/web_ui_factory.cc View 1 1 chunk +0 lines, -16 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
A + content/public/browser/web_ui_factory.h View 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2012-01-07 00:01:54 UTC) #1
Evan Stade
8 years, 11 months ago (2012-01-07 01:12:16 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698