Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: site_scons/site_tools/concat_source.py

Issue 9094: Adding in new software construction toolkit version. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/component_targets_xml.py ('k') | site_scons/site_tools/defer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/concat_source.py
===================================================================
--- site_scons/site_tools/concat_source.py (revision 4549)
+++ site_scons/site_tools/concat_source.py (working copy)
@@ -52,14 +52,7 @@
output_lines = [
'// This file is auto-generated by the ConcatSource builder.']
- for source_file in source:
- # Skip source files which are not CPP files. These will be passed through
- # to the output list by the pseudo-builder.
- if source_file.suffix not in env['CONCAT_SOURCE_SUFFIXES']:
- continue
-
- source_path = str(source_file)
-
+ for source_path in map(str, source):
if env.get('CC') == 'cl':
# Add message pragma for nicer progress indication when building with
# MSVC.
@@ -93,8 +86,9 @@
# from other files (which we pass through).
cppsource = []
outputs = []
- for source_file in SCons.Script.Flatten(source):
- if self.File(source_file).suffix in self['CONCAT_SOURCE_SUFFIXES']:
+ suffixes = self.Flatten(self.subst_list('$CONCAT_SOURCE_SUFFIXES'))
+ for source_file in self.arg2nodes(source):
+ if source_file.suffix in suffixes:
cppsource.append(source_file)
else:
outputs.append(source_file)
« no previous file with comments | « site_scons/site_tools/component_targets_xml.py ('k') | site_scons/site_tools/defer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698