Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: media/ffmpeg/ffmpeg_common.h

Issue 909002: Removed custom FFmpegLock. Removed ffmpeg headers from third_party/ffmpeg/include. (Closed)
Patch Set: Updated Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_ffmpeg.cc ('k') | media/ffmpeg/ffmpeg_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/ffmpeg/ffmpeg_common.h
diff --git a/media/ffmpeg/ffmpeg_common.h b/media/ffmpeg/ffmpeg_common.h
index 9be245ff1d418f1034c21ec33f3e57d1bdb431a3..4b600460b50722458ef1a1681f626e7f293422ce 100644
--- a/media/ffmpeg/ffmpeg_common.h
+++ b/media/ffmpeg/ffmpeg_common.h
@@ -19,34 +19,14 @@ extern "C" {
// Temporarily disable possible loss of data warning.
// TODO(scherkus): fix and upstream the compiler warnings.
MSVC_PUSH_DISABLE_WARNING(4244);
-#include "third_party/ffmpeg/include/libavcodec/avcodec.h"
-#include "third_party/ffmpeg/include/libavformat/avformat.h"
-#include "third_party/ffmpeg/include/libavutil/log.h"
+#include "third_party/ffmpeg/source/patched-ffmpeg-mt/libavcodec/avcodec.h"
+#include "third_party/ffmpeg/source/patched-ffmpeg-mt/libavformat/avformat.h"
+#include "third_party/ffmpeg/source/patched-ffmpeg-mt/libavutil/log.h"
MSVC_POP_WARNING();
} // extern "C"
namespace media {
-// FFmpegLock is used to serialize calls to avcodec_open(), avcodec_close(),
-// and av_find_stream_info() for an entire process because for whatever reason
-// it does Very Bad Things to other FFmpeg instances.
-//
-// TODO(scherkus): track down and upstream a fix to FFmpeg, if possible.
-class FFmpegLock : public Singleton<FFmpegLock> {
- public:
- Lock& lock();
-
- private:
- // Only allow Singleton to create and delete FFmpegLock.
- friend struct DefaultSingletonTraits<FFmpegLock>;
- FFmpegLock();
- virtual ~FFmpegLock();
-
- Lock lock_;
- DISALLOW_COPY_AND_ASSIGN(FFmpegLock);
-};
-
-
// Wraps FFmpeg's av_free() in a class that can be passed as a template argument
// to scoped_ptr_malloc.
class ScopedPtrAVFree {
« no previous file with comments | « media/base/mock_ffmpeg.cc ('k') | media/ffmpeg/ffmpeg_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698