Prevent recycling TCPClient socket in the case of https, so as not to crash....

net/http/http_network_transaction.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_network_transaction.h"
 
 #include "base/scoped_ptr.h"
 #include "base/compiler_specific.h"
 #include "base/string_util.h"
 #include "base/trace_event.h"
@@ skipping 739 matching lines @@
     // Error while reading the socket.
     done = true;
   } else {
     content_read_ += result;
     if (unfiltered_eof ||
         (content_length_ != -1 && content_read_ >= content_length_) ||
         (chunked_decoder_.get() && chunked_decoder_->reached_eof())) {
       done = true;
       keep_alive = response_.headers->IsKeepAlive();
       // We can't reuse the connection if we read more than the advertised
-      // content length.
-      if (unfiltered_eof ||
+      // content length, or if the tunnel was not established.

[wtc, 2008/11/04 15:08:03]

Add "successfully" after "established" to make it clear
that we tried to establish the tunnel but failed.

Nit: the ordering of the conditions in the comment should
match the ordering of the conditions in the code, to help
code comprehension.

+      if (establishing_tunnel_ || unfiltered_eof ||
           (content_length_ != -1 && content_read_ > content_length_))
         keep_alive = false;
     }
   }
 
   // Clean up the HttpConnection if we are done.
   if (done) {
     // TODO(eroman): Temporary for 3772 bug investigation.
     if (keep_alive && using_ssl_ && !connection_.socket()->IsSSL()) {
       // It is invalid to be recycling a TCPClientSocket.
@@ skipping 380 matching lines @@
     auth_data_[target]->state = AUTH_STATE_NEED_AUTH;
   }
 
   response_.auth_challenge.swap(auth_info);
   auth_handler_[target].reset(auth_handler.release());
 
   return OK;
 }
 
 }  // namespace net