Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 9087020: Fix var hiding bug in sync's UIModelWorker (Closed)

Created:
8 years, 11 months ago by rlarocque
Modified:
8 years, 11 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Fix var hiding bug in sync's UIModelWorker There's an extra declaration of error_info that hides the original declaration. We use the variable in the inner scope. When the scope ends, return the still-uninitialized variable from the outer scope. This commit fixes that bug by removing the declaration in the inner scope. BUG=105994 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/sync/glue/ui_model_worker.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rlarocque
Simple bug fix. This blocks the set of patches for fixing issue 94670 because the ...
8 years, 11 months ago (2012-01-04 22:43:02 UTC) #1
tim (not reviewing)
LGTM
8 years, 11 months ago (2012-01-05 00:14:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9087020/1
8 years, 11 months ago (2012-01-05 00:15:24 UTC) #3
commit-bot: I haz the power
Try job failure for 9087020-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 11 months ago (2012-01-05 00:55:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/9087020/1
8 years, 11 months ago (2012-01-05 17:55:18 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-05 20:36:34 UTC) #6
Change committed as 116538

Powered by Google App Engine
This is Rietveld 408576698