Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 9087008: GTK: Remove use of deprecated gtk_dialog_set_has_separator (Closed)

Created:
8 years, 11 months ago by robert.bradford
Modified:
8 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, jstritar+watch_chromium.org, Aaron Boodman, mihaip+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Remove use of deprecated gtk_dialog_set_has_separator From GTK 2.22 the separator is off by default. BUG=79722 TEST=Compiles on GTK2.16 and newer than 2.22 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116342

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/ui/gtk/about_chrome_dialog.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_editor_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_uninstall_dialog_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/input_window_dialog_gtk.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robert.bradford
8 years, 11 months ago (2012-01-04 13:54:23 UTC) #1
Elliot Glaysher
lgtm
8 years, 11 months ago (2012-01-04 17:34:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.bradford@intel.com/9087008/1
8 years, 11 months ago (2012-01-04 17:34:45 UTC) #3
commit-bot: I haz the power
8 years, 11 months ago (2012-01-04 18:46:23 UTC) #4
Change committed as 116342

Powered by Google App Engine
This is Rietveld 408576698