Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 9087006: Switch a number of code and header files from DOS to Unix line-endings. (Closed)

Created:
8 years, 11 months ago by Wez
Modified:
8 years, 11 months ago
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Switch a number of code and header files from DOS to Unix line-endings. This is mainly relevant for the IDL-generated PPAPI headers, whose line-endings reflect the convention for the platform on which they were most recently re-generated, leading to bogus whole-file diffs. Note that this CL specifically does not update the Copyright years on the affected files, since the changes are whitespace-only. BUG=109116 TEST=diff --ignore-space-at-eol should give no output for this patch. TBR=dmichael Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116311

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2451 lines, -2451 lines) Patch
M ppapi/c/ppb_view.h View 1 chunk +154 lines, -154 lines 0 comments Download
M ppapi/c/ppp_instance.h View 1 chunk +189 lines, -189 lines 0 comments Download
M ppapi/cpp/view.h View 1 chunk +114 lines, -114 lines 0 comments Download
M ppapi/cpp/view.cc View 1 chunk +62 lines, -62 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_view.h View 1 chunk +41 lines, -41 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_instance_combined.cc View 1 chunk +63 lines, -63 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_client.cc View 1 chunk +471 lines, -471 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppp_rpc_server.cc View 1 chunk +456 lines, -456 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/trusted/srpcgen/ppp_rpc.h View 1 chunk +266 lines, -266 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/untrusted/srpcgen/ppp_rpc.h View 1 chunk +295 lines, -295 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/view_data.h View 1 chunk +24 lines, -24 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/view_data.cc View 1 chunk +16 lines, -16 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.h View 1 chunk +61 lines, -61 lines 0 comments Download
M ppapi/shared_impl/ppb_view_shared.cc View 1 chunk +55 lines, -55 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.cc View 1 chunk +57 lines, -57 lines 0 comments Download
M ppapi/thunk/ppb_view_api.h View 1 chunk +31 lines, -31 lines 0 comments Download
M ppapi/thunk/ppb_view_thunk.cc View 1 chunk +96 lines, -96 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Wez
dmichael: Please review. mnissler: Please LGTM in the meantime!
8 years, 11 months ago (2012-01-04 12:16:54 UTC) #1
Mattias Nissler (ping if slow)
LGTM
8 years, 11 months ago (2012-01-04 12:38:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/9087006/1
8 years, 11 months ago (2012-01-04 12:39:33 UTC) #3
commit-bot: I haz the power
Can't apply patch for file ppapi/c/ppb_view.h. While running patch -p1 --forward --force; patching file ppapi/c/ppb_view.h ...
8 years, 11 months ago (2012-01-04 12:39:40 UTC) #4
dmichael (off chromium)
8 years, 11 months ago (2012-01-04 15:43:12 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698