Issue 9086015: Report error for interface method with body, issue 971

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9086015: Report error for interface method with body, issue 971 (Closed)

Created:
8 years, 11 months ago by scheglov

Modified:
8 years, 11 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report error for interface method with body http://code.google.com/p/dart/issues/detail?id=971 R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3000

Patch Set 2 : Rollback extra change #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -19 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	2 chunks	+22 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zundel

http://codereview.chromium.org/9086015/diff/1/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java File compiler/java/com/google/dart/compiler/ast/LibraryUnit.java (right): http://codereview.chromium.org/9086015/diff/1/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java#newcode261 compiler/java/com/google/dart/compiler/ast/LibraryUnit.java:261: int endIdx; move endIdx decl inside while loop. http://codereview.chromium.org/9086015/diff/1/compiler/java/com/google/dart/compiler/ast/LibraryUnit.java#newcode269 ...

8 years, 11 months ago (2012-01-04 21:37:51 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 9086015: Report error for interface method with body, issue 971 (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rollback extra change #

Messages