Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 9086006: Randomize the seed used for string hashing. This helps guard against (Closed)

Created:
8 years, 11 months ago by Erik Corry
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Randomize the seed used for string hashing. This helps guard against CPU-eating DOS attacks against node.js servers. Based on code from Bert Belder. This version only solves the issue for those that compile V8 themselves or those that do not use snapshots. A snapshot-based precompiled V8 will still have predictable string hash codes. Committed: http://code.google.com/p/v8/source/detail?r=10330

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -66 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +6 lines, -0 lines 2 comments Download
M src/heap.h View 3 chunks +8 lines, -2 lines 0 comments Download
M src/heap.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +18 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +9 lines, -5 lines 2 comments Download
M src/objects.h View 3 chunks +6 lines, -3 lines 0 comments Download
M src/objects.cc View 14 chunks +51 lines, -27 lines 2 comments Download
M src/objects-inl.h View 3 chunks +10 lines, -7 lines 0 comments Download
M src/profile-generator.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals-optimized.js View 2 chunks +7 lines, -5 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals-optimized-double.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Erik Corry
8 years, 11 months ago (2012-01-04 14:06:47 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352 src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes, Maybe it should be noted that data ...
8 years, 11 months ago (2012-01-04 14:30:56 UTC) #2
Erik Corry
http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): http://codereview.chromium.org/9086006/diff/1/src/flag-definitions.h#newcode352 src/flag-definitions.h:352: DEFINE_bool(randomize_string_hashes, On 2012/01/04 14:30:57, Vyacheslav Egorov wrote: > Maybe ...
8 years, 11 months ago (2012-01-04 15:48:59 UTC) #3
ry
Hi Erik, Can you back port this to 3.6? feel free to use my attempt ...
8 years, 11 months ago (2012-01-04 23:46:56 UTC) #4
ry
I talked with Slave a bit today and tried to get the patch working on ...
8 years, 11 months ago (2012-01-05 22:33:47 UTC) #5
ry
8 years, 11 months ago (2012-01-05 22:34:27 UTC) #6
On 2012/01/05 22:33:47, ry wrote:
> I talked with Slave 

s/Slave/Slav/ sorry

Powered by Google App Engine
This is Rietveld 408576698