Issue 9086005: When shrinking semispace don't relink pages if semispace is not committed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9086005: When shrinking semispace don't relink pages if semispace is not committed (Closed)

Created:
8 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
8 years, 11 months ago

Reviewers:
Sven Panne, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

When shrinking semispace don't relink pages if semispace is not committed R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=10333

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/spaces.cc	View		1 chunk	+6 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). http://codereview.chromium.org/9086005/diff/1/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/9086005/diff/1/src/spaces.cc#newcode1272 src/spaces.cc:1272: if (!is_committed()) { Can we ...

8 years, 11 months ago (2012-01-04 14:38:28 UTC) #2

Sven Panne

8 years, 11 months ago (2012-01-04 14:46:54 UTC) #3

http://codereview.chromium.org/9086005/diff/1/src/spaces.cc
File src/spaces.cc (right):

http://codereview.chromium.org/9086005/diff/1/src/spaces.cc#newcode1272
src/spaces.cc:1272: if (!is_committed()) {
On 2012/01/04 14:38:28, Michael Starzinger wrote:
> Can we invert the condition and place the block below inside the if statement?
I
> like that better than early returns.

Drive-by comment: I *do* like guard clauses, they can make the normal control
flow much clearer.
(http://martinfowler.com/refactoring/catalog/replaceNestedConditionalWithGuard...)

Just my 2c... :-)

Expand Messages | Collapse Messages