Issue 9085016: Fix bug 1011

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9085016: Fix bug 1011 (Closed)

Created:
8 years, 11 months ago by jimhug

Modified:
8 years, 11 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make sure that we generate nice errors even if a DeclaredIdentifier escapes the parser as an expression. No tests included because test infrastructure can not currently tell the difference between an internal error and a nice syntax error. Committed: https://code.google.com/p/dart/source/detail?r=2958

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	frog/gen.dart	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	frog/minfrog	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

8 years, 11 months ago (2012-01-04 18:30:11 UTC) #2

On 2012/01/04 18:29:00, jimhug wrote:
> TBR

lgtm.

> No tests included because test infrastructure can not currently tell the
difference between an internal error and a nice syntax error.

yeah, I hit that one a lot too :\

Expand Messages | Collapse Messages