Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 9085006: Replace Browser::GetTabContentsAt with GetWebContentsAt and update all callers. (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Jói
CC:
chromium-reviews, nkostylev+watch_chromium.org, tburkard+watch_chromium.org, jam, mihaip+watch_chromium.org, dcheng, ajwong+watch_chromium.org, creis+watch_chromium.org, stevenjb+watch_chromium.org, cbentzel+watch_chromium.org, kkania, joi+watch-content_chromium.org, anantha, darin-cc_chromium.org, brettw-cc_chromium.org, dennis_jeffrey, jstritar+watch_chromium.org, Avi (use Gerrit), John Grabowski, dpranke-watch+content_chromium.org, Nirnimesh, Aaron Boodman, dominich+watch_chromium.org, eroman, robertshield, davemoore+watch_chromium.org, dyu1, estade+watch_chromium.org, mmenke
Visibility:
Public.

Description

Replace Browser::GetTabContentsAt with GetWebContentsAt and update all callers. BUG=98716 TBR=joi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116322

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : fix mac #

Patch Set 5 : fix mac again #

Patch Set 6 : fix mac yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -525 lines) Patch
M chrome/browser/automation/automation_provider_json.h View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/automation/automation_provider_json.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_util.h View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/automation/automation_util.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 42 chunks +82 lines, -83 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_commands_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_keyevents_browsertest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/tab_closeable_state_watcher.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 22 chunks +49 lines, -49 lines 0 comments Download
M chrome/browser/extensions/extension_browsertests_misc.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_cookies_helpers.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_devtools_browsertests.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/isolated_app_browsertest.cc View 6 chunks +28 lines, -25 lines 0 comments Download
M chrome/browser/oom_priority_manager.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/renderer_host/web_cache_manager_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_delegate.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sidebar/sidebar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_util.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/tab_util.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/tabs/tab_finder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 13 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_order_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.h View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser_init.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_init_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 10 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/window_applescript.mm View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/sidebar_controller.mm View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 2 3 4 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 18 chunks +26 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 3 4 5 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/drag_data.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/drag_data.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 1 2 10 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_view_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 1 2 3 5 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/tabs/default_tab_drag_controller.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/net_internals_ui_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/child_process_security_policy_browsertest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2012-01-04 01:53:14 UTC) #1
Jói
8 years, 11 months ago (2012-01-04 11:10:11 UTC) #2
LGTM

For posterity, this also changes Browser::AddRestoredTab to return a
content::WebContents* instead of a TabContents*.

On Wed, Jan 4, 2012 at 1:53 AM, <jam@chromium.org> wrote:
>
> Reviewers: Jói,
>
> Description:
> Replace Browser::GetTabContentsAt with GetWebContentsAt and update all
callers.
>
> BUG=98716
> TBR=joi
>
> Please review this at http://codereview.chromium.org/9085006/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/automation/automation_provider_json.h
>  M     chrome/browser/automation/automation_provider_json.cc
>  M     chrome/browser/automation/automation_util.h
>  M     chrome/browser/automation/automation_util.cc
>  M     chrome/browser/automation/testing_automation_provider.h
>  M     chrome/browser/automation/testing_automation_provider.cc
>  M     chrome/browser/bookmarks/bookmark_utils.cc
>  M     chrome/browser/browser_commands_unittest.cc
>  M     chrome/browser/browser_focus_uitest.cc
>  M     chrome/browser/browser_keyevents_browsertest.cc
>  M     chrome/browser/chromeos/boot_times_loader.cc
>  M     chrome/browser/chromeos/tab_closeable_state_watcher.cc
>  M     chrome/browser/custom_home_pages_table_model.cc
>  M     chrome/browser/debugger/devtools_sanity_unittest.cc
>  M     chrome/browser/extensions/app_process_apitest.cc
>  M     chrome/browser/extensions/extension_browsertests_misc.cc
>  M     chrome/browser/extensions/extension_cookies_helpers.cc
>  M     chrome/browser/extensions/extension_devtools_browsertests.cc
>  M     chrome/browser/extensions/extension_tab_util.cc
>  M     chrome/browser/extensions/isolated_app_browsertest.cc
>  M     chrome/browser/oom_priority_manager.cc
>  M     chrome/browser/prerender/prerender_contents.cc
>  M     chrome/browser/renderer_host/web_cache_manager_browsertest.cc
>  M     chrome/browser/sessions/session_restore_browsertest.cc
>  M     chrome/browser/sessions/tab_restore_service.cc
>  M     chrome/browser/sessions/tab_restore_service_delegate.h
>  M     chrome/browser/sidebar/sidebar_browsertest.cc
>  M     chrome/browser/tab_contents/tab_util.h
>  M     chrome/browser/tab_contents/tab_util.cc
>  M     chrome/browser/tabs/pinned_tab_codec.cc
>  M     chrome/browser/tabs/tab_finder.cc
>  M     chrome/browser/tabs/tab_strip_model.cc
>  M     chrome/browser/tabs/tab_strip_model_order_controller.cc
>  M     chrome/browser/ui/browser.h
>  M     chrome/browser/ui/browser.cc
>  M     chrome/browser/ui/browser_browsertest.cc
>  M     chrome/browser/ui/browser_init.cc
>  M     chrome/browser/ui/browser_init_browsertest.cc
>  M     chrome/browser/ui/browser_navigator.cc
>  M     chrome/browser/ui/browser_tab_restore_service_delegate.h
>  M     chrome/browser/ui/browser_tab_restore_service_delegate.cc
>  M     chrome/browser/ui/cocoa/applescript/window_applescript.mm
>  M     chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller.mm
>  M     chrome/browser/ui/cocoa/tabpose_window.mm
>  M     chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
>  M     chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.h
>  M     chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc
>  M     chrome/browser/ui/gtk/tabs/tab_gtk.h
>  M     chrome/browser/ui/gtk/tabs/tab_gtk.cc
>  M     chrome/browser/ui/gtk/tabs/tab_renderer_gtk.h
>  M     chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc
>  M     chrome/browser/ui/gtk/tabs/tab_strip_gtk.h
>  M     chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc
>  M     chrome/browser/ui/toolbar/toolbar_model_unittest.cc
>  M     chrome/browser/ui/views/find_bar_host_interactive_uitest.cc
>  M     chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc
>  M     chrome/browser/ui/views/tabs/default_tab_drag_controller.cc
>  M     chrome/browser/ui/webui/net_internals_ui_browsertest.cc
>  M     chrome/browser/ui/webui/ntp/new_tab_ui_browsertest.cc
>  M     chrome/test/base/ui_test_utils.cc
>  M     content/browser/renderer_host/render_process_host_browsertest.cc
>
>

Powered by Google App Engine
This is Rietveld 408576698