Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 9075003: Fix several minor issues with grokdump.py tool. (Closed)

Created:
8 years, 11 months ago by Michael Starzinger
Modified:
8 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix several minor issues with grokdump.py tool. This includes the following changes: * Bring instance type mapping up to date. * Enable loading of maps without available meta-map. * Add missing IntSize() method. * Fix reference to Code.CODE_ALIGNMENT_MASK. * Add alignment checks for objects and maps. R=vegorov@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=10344

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Vyacheslav Egorov. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -41 lines) Patch
M tools/grokdump.py View 1 8 chunks +71 lines, -41 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
LGTM http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py File tools/grokdump.py (right): http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py#newcode957 tools/grokdump.py:957: def FindMap(self, tagged_address): One trick that might help ...
8 years, 11 months ago (2012-01-04 08:45:34 UTC) #1
Michael Starzinger
8 years, 11 months ago (2012-01-05 14:26:29 UTC) #2
Added new patch set.

http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

http://codereview.chromium.org/9075003/diff/1/tools/grokdump.py#newcode957
tools/grokdump.py:957: def FindMap(self, tagged_address):
On 2012/01/04 08:45:35, Vyacheslav Egorov wrote:
> One trick that might help to guess whether smth is map or not is maps
alignment
> --- it's bigger than alignment of normal objects.

Done. I also added the alignment check for other heap objects.

Powered by Google App Engine
This is Rietveld 408576698