Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 9074003: Fix handling of bogus receivers for Harmony collections. (Closed)

Created:
8 years, 11 months ago by Michael Starzinger
Modified:
8 years, 11 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix handling of bogus receivers for Harmony collections. R=rossberg@chromium.org BUG=v8:1884 TEST=mjsunit/harmony/collections Committed: http://code.google.com/p/v8/source/detail?r=10342

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M src/collection.js View 11 chunks +44 lines, -0 lines 0 comments Download
M src/macros.py View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/collections.js View 1 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
8 years, 11 months ago (2012-01-03 10:59:46 UTC) #1
rossberg
http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js#newcode286 test/mjsunit/harmony/collections.js:286: assertThrows(function () { func.call({}, {}) }, TypeError); Particularly interesting ...
8 years, 11 months ago (2012-01-04 10:06:59 UTC) #2
Michael Starzinger
PTAL. http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js File test/mjsunit/harmony/collections.js (right): http://codereview.chromium.org/9074003/diff/1/test/mjsunit/harmony/collections.js#newcode286 test/mjsunit/harmony/collections.js:286: assertThrows(function () { func.call({}, {}) }, TypeError); On ...
8 years, 11 months ago (2012-01-05 10:40:03 UTC) #3
rossberg
8 years, 11 months ago (2012-01-05 12:49:01 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698