Issue 9074: Port more of url_request_unittest.cc....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9074: Port more of url_request_unittest.cc.... (Closed)

Created:
12 years, 1 month ago by dank

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Port more of url_request_unittest.cc. Also do a little bit of the FilePath rewrite as it pertains to this test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4652

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	base/file_util.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	base/file_util.cc	View	2 chunks	+7 lines, -1 line	1 comment	Download
M	base/file_util_posix.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/file_util_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	2 chunks	+4 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dank

Port more of PostFileTest, and do a little hunk of the FilePath rewrite.

12 years, 1 month ago (2008-11-04 20:04:39 UTC) #1

agl

12 years, 1 month ago (2008-11-04 20:57:27 UTC) #2

LGTM

http://codereview.chromium.org/9074/diff/1/6
File base/file_util.cc (right):

http://codereview.chromium.org/9074/diff/1/6#newcode352
Line 352: }
Possibly put a line between the functions.

Expand Messages | Collapse Messages