Issue 9071026: Copy changes in r115955 from options to options2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9071026: Copy changes in r115955 from options to options2 (Closed)

Created:
8 years, 11 months ago by Tyler Breisacher (Chromium)

Modified:
8 years, 11 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews), mnaganov (inactive)

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Copy changes in r115955 from options to options2 BUG=NONE TEST=Uberpage doesn't cause crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116265

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -26 lines)			Patch
M	chrome/browser/resources/options2/font_settings.html	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/advanced_options_handler2.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/font_settings_handler2.cc	View	2 chunks	+19 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/font_settings_utils2_mac.mm	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

Tyler Breisacher (Chromium)

I'm getting some DCHECK failures when loading the uberpage and it seems to be because ...

8 years, 11 months ago (2012-01-03 23:10:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9071026/1

8 years, 11 months ago (2012-01-03 23:44:49 UTC) #3

Change committed as 116265