Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: base/task.h

Issue 9071023: base::Bind: Remove CancelableTask and ScopedTaskRunner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task.h
diff --git a/base/task.h b/base/task.h
index 33044cae1a84042e2f2b3ae06fc0d2abdcbfbb04..a310e0d4f0d53fce9f0ad8587fa634982b42af90 100644
--- a/base/task.h
+++ b/base/task.h
@@ -56,15 +56,6 @@ class BASE_EXPORT Task {
virtual void Run() = 0;
};
-class BASE_EXPORT CancelableTask : public Task {
- public:
- CancelableTask();
- virtual ~CancelableTask();
-
- // Not all tasks support cancellation.
- virtual void Cancel() = 0;
-};
-
template<typename T>
void DeletePointer(T* obj) {
delete obj;
@@ -72,22 +63,8 @@ void DeletePointer(T* obj) {
namespace base {
-// ScopedTaskRunner is akin to scoped_ptr for Tasks. It ensures that the Task
-// is executed and deleted no matter how the current scope exits.
-class BASE_EXPORT ScopedTaskRunner {
- public:
- // Takes ownership of the task.
- explicit ScopedTaskRunner(Task* task);
- ~ScopedTaskRunner();
-
- Task* Release();
-
- private:
- Task* task_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(ScopedTaskRunner);
-};
-
+// ScopedClosureRunner is akin to scoped_ptr for Closures. It ensures that the
+// Closure is executed and deleted no matter how the current scope exits.
class BASE_EXPORT ScopedClosureRunner {
public:
explicit ScopedClosureRunner(const Closure& closure);
« no previous file with comments | « no previous file | base/task.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698