Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Unified Diff: chrome/browser/history/in_memory_url_index_unittest.cc

Issue 9071014: Database usage adjustment for .../history (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplify SQL Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/in_memory_database.cc ('k') | chrome/browser/history/shortcuts_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/in_memory_url_index_unittest.cc
diff --git a/chrome/browser/history/in_memory_url_index_unittest.cc b/chrome/browser/history/in_memory_url_index_unittest.cc
index cd9a068a9af2122edfa88251aba7816f29002932..d249f393554cb4aac319fe6da03e753e2c52678d 100644
--- a/chrome/browser/history/in_memory_url_index_unittest.cc
+++ b/chrome/browser/history/in_memory_url_index_unittest.cc
@@ -102,7 +102,7 @@ void InMemoryURLIndexTest::SetUp() {
// such that it represents a time relative to 'now'.
sql::Statement statement(db.GetUniqueStatement(
"SELECT" HISTORY_URL_ROW_FIELDS "FROM urls;"));
- EXPECT_TRUE(statement);
+ ASSERT_TRUE(statement.is_valid());
base::Time time_right_now = base::Time::NowFromSystemTime();
base::TimeDelta day_delta = base::TimeDelta::FromDays(1);
{
@@ -204,7 +204,7 @@ TEST_F(LimitedInMemoryURLIndexTest, Initialization) {
// Verify that the database contains the expected number of items, which
// is the pre-filtered count, i.e. all of the items.
sql::Statement statement(GetDB().GetUniqueStatement("SELECT * FROM urls;"));
- EXPECT_TRUE(statement);
+ ASSERT_TRUE(statement.is_valid());
uint64 row_count = 0;
while (statement.Step()) ++row_count;
EXPECT_EQ(1U, row_count);
« no previous file with comments | « chrome/browser/history/in_memory_database.cc ('k') | chrome/browser/history/shortcuts_database.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698