Database usage adjustment for .../history

chrome/browser/history/download_database.h

Index: chrome/browser/history/download_database.h
diff --git a/chrome/browser/history/download_database.h b/chrome/browser/history/download_database.h
index f03a40e51f62034f1fb5511c9b0c261706ac6f72..9bf8ed3aae42318ce6a657797c31790f6869f8a5 100644
--- a/chrome/browser/history/download_database.h
+++ b/chrome/browser/history/download_database.h
@@ -58,7 +58,7 @@ class DownloadDatabase {
   // (inclusive) and before |remove_end|. You may use null Time values
   // to do an unbounded delete in either direction. This function ignores
   // all downloads that are in progress or are waiting to be cancelled.
-  void RemoveDownloadsBetween(base::Time remove_begin, base::Time remove_end);
+  bool RemoveDownloadsBetween(base::Time remove_begin, base::Time remove_end);

[Scott Hess - ex-Googler, 2012/01/04 00:06:40]

BTW: Where you've converted void->bool, consider WARN_UNUSED_RESULT to make
checking the return value part of the contract.  I'd like to use that in more of
the persistence code, but for most cases it involves tracking callers down and
figuring out how to deal with things, whereas in this case you're already
on-site...

[Greg Billock, 2012/01/04 19:20:20]

Yeah. This particular case is used only in a ScheduleAndForget call.

On 2012/01/04 00:06:40, shess wrote:

 
  protected:
   // Returns the database for the functions in this interface.