Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: chrome/browser/history/url_database_unittest.cc

Issue 9071014: Database usage adjustment for .../history (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Simplify SQL Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/url_database.cc ('k') | chrome/browser/history/visit_database.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/file_path.h" 5 #include "base/file_path.h"
6 #include "base/file_util.h" 6 #include "base/file_util.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/scoped_temp_dir.h" 8 #include "base/scoped_temp_dir.h"
9 #include "base/string_util.h" 9 #include "base/string_util.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 232
233 // Insert a row with favicon 233 // Insert a row with favicon
234 URLID url_id1 = AddURL(url_info1); 234 URLID url_id1 = AddURL(url_info1);
235 ASSERT_TRUE(url_id1 != 0); 235 ASSERT_TRUE(url_id1 != 0);
236 236
237 FaviconID icon_id = 1; 237 FaviconID icon_id = 1;
238 sql::Statement statement(GetDB().GetCachedStatement( 238 sql::Statement statement(GetDB().GetCachedStatement(
239 SQL_FROM_HERE, 239 SQL_FROM_HERE,
240 "UPDATE urls SET favicon_id =? WHERE id=?")); 240 "UPDATE urls SET favicon_id =? WHERE id=?"));
241 241
242 ASSERT_TRUE(statement); 242 ASSERT_TRUE(statement.is_valid());
243 243
244 statement.BindInt64(0, icon_id); 244 statement.BindInt64(0, icon_id);
245 statement.BindInt64(1, url_id1); 245 statement.BindInt64(1, url_id1);
246 ASSERT_TRUE(statement.Run()); 246 ASSERT_TRUE(statement.Run());
247 247
248 // Insert another row without favicon 248 // Insert another row without favicon
249 const GURL url2("http://www.google.com/no_icon"); 249 const GURL url2("http://www.google.com/no_icon");
250 URLRow url_info2(url2); 250 URLRow url_info2(url2);
251 url_info2.set_title(UTF8ToUTF16("Google")); 251 url_info2.set_title(UTF8ToUTF16("Google"));
252 url_info2.set_visit_count(4); 252 url_info2.set_visit_count(4);
253 url_info2.set_typed_count(2); 253 url_info2.set_typed_count(2);
254 url_info2.set_last_visit(Time::Now() - TimeDelta::FromDays(1)); 254 url_info2.set_last_visit(Time::Now() - TimeDelta::FromDays(1));
255 url_info2.set_hidden(false); 255 url_info2.set_hidden(false);
256 256
257 // Insert a row with favicon 257 // Insert a row with favicon
258 URLID url_id2 = AddURL(url_info2); 258 URLID url_id2 = AddURL(url_info2);
259 ASSERT_TRUE(url_id2 != 0); 259 ASSERT_TRUE(url_id2 != 0);
260 260
261 IconMappingEnumerator e; 261 IconMappingEnumerator e;
262 InitIconMappingEnumeratorForEverything(&e); 262 InitIconMappingEnumeratorForEverything(&e);
263 IconMapping icon_mapping; 263 IconMapping icon_mapping;
264 ASSERT_TRUE(e.GetNextIconMapping(&icon_mapping)); 264 ASSERT_TRUE(e.GetNextIconMapping(&icon_mapping));
265 ASSERT_EQ(url1, icon_mapping.page_url); 265 ASSERT_EQ(url1, icon_mapping.page_url);
266 ASSERT_EQ(icon_id, icon_mapping.icon_id); 266 ASSERT_EQ(icon_id, icon_mapping.icon_id);
267 ASSERT_FALSE(e.GetNextIconMapping(&icon_mapping)); 267 ASSERT_FALSE(e.GetNextIconMapping(&icon_mapping));
268 } 268 }
269 269
270 } // namespace history 270 } // namespace history
OLDNEW
« no previous file with comments | « chrome/browser/history/url_database.cc ('k') | chrome/browser/history/visit_database.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698