Issue 9071004: Add netbsd support to gyp build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9071004: Add netbsd support to gyp build. (Closed)

Created:
8 years, 11 months ago by Yang

Modified:
8 years, 11 months ago

Reviewers:
msporleder

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add netbsd support to gyp build. Committed: http://code.google.com/p/v8/source/detail?r=10341

Patch Set 1 #

Patch Set 2 : Applied suggested changes #

Patch Set 3 : remove strict-aliasing warning #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -21 lines)			Patch
M	build/common.gypi	View	1 2	5 chunks	+11 lines, -4 lines	0 comments	Download
M	build/standalone.gypi	View	1	4 chunks	+15 lines, -9 lines	0 comments	Download
M	src/d8.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/d8-posix.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/platform-openbsd.cc	View	1	3 chunks	+17 lines, -4 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 11 months ago (2012-01-03 10:28:58 UTC) #1

I revamped your patch to include NetBSD support in the GYP build for V8.  Since
platform-netbsd.cc shares a lot of code with platform-openbsd.cc, I merged them
and now use a define flag to distinguish.

Please take a look and confirm that the patch works!

Expand Messages | Collapse Messages