Issue 9071001: base::Bind: Remove ScopedRunnableMethodFactory.

Issue 9071001: base::Bind: Remove ScopedRunnableMethodFactory. (Closed)

Created:
8 years, 11 months ago by James Hawkins

Modified:
8 years, 11 months ago

Reviewers:
Sergey Ulanov, groby-ooo-7-16, awong, csilv

CC:
chromium-reviews, nkostylev+watch_chromium.org, amit, dcheng, stevenjb+watch_chromium.org, jam, prasadt, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, michaeln, jennb, wez+watch_chromium.org, sanjeevr, jianli, dpranke-watch+content_chromium.org, simonmorris+watch_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, Dmitry Titov, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

base::Bind: Remove ScopedRunnableMethodFactory. BUG=none TEST=none R=groby,awong,csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116198

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review fixes. #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -201 lines)			Patch
M	base/task.h	View	1	2 chunks	+1 line, -143 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/offline/offline_load_page.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/history/history_backend.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_gtk.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window_gtk.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/test/base/view_event_test_base.h	View	1	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/test/base/view_event_test_base.cc	View	1	3 chunks	+2 lines, -7 lines	0 comments	Download
M	content/browser/download/save_package.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	content/browser/download/save_package.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/base/scoped_thread_proxy.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	remoting/protocol/jingle_session_manager.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	remoting/protocol/jingle_session_manager.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.h	View	1	3 chunks	+1 line, -5 lines	0 comments	Download
M	webkit/appcache/appcache_update_job.cc	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

src/remoting LGTM when my comment is addressed. http://codereview.chromium.org/9071001/diff/1/remoting/base/scoped_thread_proxy.h File remoting/base/scoped_thread_proxy.h (left): http://codereview.chromium.org/9071001/diff/1/remoting/base/scoped_thread_proxy.h#oldcode18 remoting/base/scoped_thread_proxy.h:18: // The ...

8 years, 11 months ago (2012-01-03 18:48:59 UTC) #3

csilv

lgtm http://codereview.chromium.org/9071001/diff/1/base/task.h File base/task.h (right): http://codereview.chromium.org/9071001/diff/1/base/task.h#newcode1 base/task.h:1: // Copyright (c) 2011 The Chromium Authors. All ...

8 years, 11 months ago (2012-01-03 18:57:42 UTC) #4

James Hawkins

http://codereview.chromium.org/9071001/diff/1/base/task.h File base/task.h (right): http://codereview.chromium.org/9071001/diff/1/base/task.h#newcode1 base/task.h:1: // Copyright (c) 2011 The Chromium Authors. All rights ...

8 years, 11 months ago (2012-01-03 21:13:53 UTC) #5

James Hawkins

8 years, 11 months ago (2012-01-03 21:14:28 UTC) #6

Going off the green tryjob runs from PS1 since PS2 is composed of trivial
changes.

Expand Messages | Collapse Messages