Issue 907004: Fix @hash in DEPS file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 907004: Fix @hash in DEPS file (Closed)

Created:
10 years, 9 months ago by Nasser Grainawi

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, linuxzsc

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Fix @hash in DEPS file Broken by the @branchname support Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41585

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	gclient_scm.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I don't totally follow the code path here. It would probably be worth splitting the ...

10 years, 9 months ago (2010-03-13 01:58:09 UTC) #2

Nasser Grainawi

10 years, 9 months ago (2010-03-15 15:05:22 UTC) #3

On 2010/03/13 01:58:09, Marc-Antoine Ruel wrote:
> I don't totally follow the code path here. It would probably be worth
splitting
> the function up.
> 
> rubberstamp lgtm

Yeah, I think my original assumptions about when case 1 would be used were
wrong.
I'll commit this for now, but I do plan on coming back in and reworking this
function again.

Expand Messages | Collapse Messages