Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9064006: Convert DeviceTokenFetcher and CloudPolicyController response callbacks. (Closed)

Created:
8 years, 11 months ago by Mattias Nissler (ping if slow)
Modified:
8 years, 11 months ago
Reviewers:
Joao da Silva
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Convert DeviceTokenFetcher and CloudPolicyController response callbacks. BUG=chromium:108928 TEST=Compiles and passes tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116133

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : another nit. #

Total comments: 8

Patch Set 4 : Address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -277 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/browser_policy_connector.h View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller.h View 1 2 3 chunks +14 lines, -11 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller.cc View 1 2 3 6 chunks +64 lines, -53 lines 0 comments Download
M chrome/browser/policy/cloud_policy_controller_unittest.cc View 1 2 3 15 chunks +67 lines, -52 lines 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/policy/cloud_policy_data_store.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher.h View 4 chunks +17 lines, -13 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher.cc View 5 chunks +79 lines, -67 lines 0 comments Download
M chrome/browser/policy/device_token_fetcher_unittest.cc View 9 chunks +27 lines, -23 lines 0 comments Download
M chrome/browser/policy/mock_device_management_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/policy/proto/device_management_constants.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/policy/proto/device_management_constants.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mattias Nissler (ping if slow)
Moar reviews!
8 years, 11 months ago (2012-01-02 18:17:17 UTC) #1
Joao da Silva
LGTM with moar nits http://codereview.chromium.org/9064006/diff/3002/chrome/browser/policy/browser_policy_connector.cc File chrome/browser/policy/browser_policy_connector.cc (right): http://codereview.chromium.org/9064006/diff/3002/chrome/browser/policy/browser_policy_connector.cc#newcode17 chrome/browser/policy/browser_policy_connector.cc:17: #include "chrome/browser/policy/configuration_policy_pref_store.h" Nit: not used ...
8 years, 11 months ago (2012-01-03 08:19:02 UTC) #2
Mattias Nissler (ping if slow)
Nits addressed. Thanks for the review! http://codereview.chromium.org/9064006/diff/3002/chrome/browser/policy/browser_policy_connector.cc File chrome/browser/policy/browser_policy_connector.cc (right): http://codereview.chromium.org/9064006/diff/3002/chrome/browser/policy/browser_policy_connector.cc#newcode17 chrome/browser/policy/browser_policy_connector.cc:17: #include "chrome/browser/policy/configuration_policy_pref_store.h" On ...
8 years, 11 months ago (2012-01-03 10:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9064006/8003
8 years, 11 months ago (2012-01-03 10:03:01 UTC) #4
commit-bot: I haz the power
Can't apply patch for file chrome/browser/policy/cloud_policy_controller_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/policy/cloud_policy_controller_unittest.cc ...
8 years, 11 months ago (2012-01-03 10:03:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9064006/8003
8 years, 11 months ago (2012-01-03 11:42:02 UTC) #6
commit-bot: I haz the power
Can't apply patch for file chrome/browser/policy/cloud_policy_controller_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/policy/cloud_policy_controller_unittest.cc ...
8 years, 11 months ago (2012-01-03 12:45:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnissler@chromium.org/9064006/8003
8 years, 11 months ago (2012-01-03 13:22:30 UTC) #8
commit-bot: I haz the power
8 years, 11 months ago (2012-01-03 14:28:10 UTC) #9 
Change committed as 116133

Powered by Google App Engine
This is Rietveld 408576698