Use CreateThread instead of _beginthreadex. This should still be safe, and w...

Use CreateThread instead of _beginthreadex.  This should still be safe, and we'll see if it makes a noticable impact on startup time.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4580

[Dean McNamee, 2008-11-03 22:05:04]

From my traces, looks like it helps.

[Peter Kasting, 2008-11-03 22:09:29]

http://codereview.chromium.org/9059/diff/1/2
File base/platform_thread_win.cc (right):

http://codereview.chromium.org/9059/diff/1/2#newcode53
Line 53: if (0 && !::IsDebuggerPresent())
Did you mean this change to be part of this CL?  Looks like a local
modification.

[darin (slow to review), 2008-11-03 22:18:33]

LGTM w/ the bogus if (0) removed.

[M-A Ruel, 2008-11-03 22:22:11]

If we ever see glitches, it's relatively easy to roll back.

lgtm

http://codereview.chromium.org/9059/diff/1/2
File base/platform_thread_win.cc (right):

http://codereview.chromium.org/9059/diff/1/2#newcode83
Line 83: //   http://www.microsoft.com/msj/1099/win32/win321099.aspx
Add these links too:
http://msdn.microsoft.com/en-us/library/kdzttdcb.aspx
http://msdn.microsoft.com/en-us/library/7t9ha0zh.aspx

[cpu_(ooo_6.6-7.5), 2008-11-04 03:07:58]

The full source code to _beginthreadex is here:

C:\Program Files\Microsoft Visual Studio 8\VC\crt\src\threadex.c

It seems to be doing a lot of things, do we know what happens if we don't call
_FPmtinit for example?

Maybe the argument is moot sice the crt should be doing all this in the dllmain
callback.

I'll be curious to see what the speed improvement is anyway.

http://codereview.chromium.org/9059/diff/1/2
File base/platform_thread_win.cc (right):

http://codereview.chromium.org/9059/diff/1/2#newcode7
Line 7: #include <process.h>
remove this include

[rtanabe999, 2008-11-04 08:29:10]

A thread in an executable that calls the C run-time library (CRT) should use the
_beginthreadex and _endthreadex functions for thread management rather than
CreateThread and ExitThread; this requires the use of the multi-threaded version
of the CRT. If a thread created using CreateThread calls the CRT, the CRT may
terminate the process in low-memory conditions.

http://msdn.microsoft.com/en-us/library/ms682453(VS.85).aspx

[tommi (sloooow) - chröme, 2008-11-30 05:29:32]

http://codereview.chromium.org/9059/diff/1/2
File base/platform_thread_win.cc (right):

http://codereview.chromium.org/9059/diff/1/2#newcode80
Line 80: // faster and doesn't require holding the loader lock.  Our code will
have
hi... really late, drive by comment here.  I noticed this line "doesn't require
holding the loader lock" for CreateThread. Actually even with CreateThread when
a thread starts, it does acquire the loader lock in order to call
DllMain(DLL_THREAD_ATTACH) for all dlls that haven't opted out of those calls.
just an fyi.
the _beginthreadex() call adds a crt thread stub that sets up TLS stuff.  I
doubt that chrome depends on it though, so the change is fine by me.  Just an
fyi on the comment in the code.