Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 9057001: Update Sleep() calls in base/test to use TimeDelta instead of int. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update Sleep() calls in base/test to use TimeDelta instead of int. R=phajdan.jr@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116320

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make variable names style guide consistent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M base/test/test_file_util_win.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M base/test/trace_event_analyzer_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ted Vessenes
8 years, 11 months ago (2011-12-30 22:12:54 UTC) #1
Paweł Hajdan Jr.
http://codereview.chromium.org/9057001/diff/1/base/test/test_file_util_win.cc File base/test/test_file_util_win.cc (right): http://codereview.chromium.org/9057001/diff/1/base/test/test_file_util_win.cc#newcode66 base/test/test_file_util_win.cc:66: const int iters = 25; nit: No abbreviations, also ...
8 years, 11 months ago (2012-01-03 08:06:46 UTC) #2
Ted Vessenes
Fixed as requested.
8 years, 11 months ago (2012-01-03 15:18:05 UTC) #3
Paweł Hajdan Jr.
LGTM
8 years, 11 months ago (2012-01-04 08:41:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9057001/3002
8 years, 11 months ago (2012-01-04 14:35:11 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2012-01-04 16:48:51 UTC) #6
Change committed as 116320

Powered by Google App Engine
This is Rietveld 408576698