Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 9056001: Update Sleep() calls in metrics tests to use TimeDelta instead of int. (Closed)

Created:
8 years, 11 months ago by Ted Vessenes
Modified:
8 years, 11 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update Sleep() calls in metrics tests to use TimeDelta instead of int. R=jar@chromium.org BUG=108171 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116064

Patch Set 1 #

Total comments: 1

Patch Set 2 : Give duration variable a better name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M base/metrics/stats_table_unittest.cc View 1 5 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ted Vessenes
8 years, 11 months ago (2011-12-30 22:12:11 UTC) #1
jar (doing other things)
http://codereview.chromium.org/9056001/diff/1/base/metrics/stats_table_unittest.cc File base/metrics/stats_table_unittest.cc (right): http://codereview.chromium.org/9056001/diff/1/base/metrics/stats_table_unittest.cc#newcode318 base/metrics/stats_table_unittest.cc:318: const TimeDelta kRun = TimeDelta::FromMilliseconds(100); nit: please change the ...
8 years, 11 months ago (2011-12-31 08:08:16 UTC) #2
Ted Vessenes
Agreed. Fixed as requested. On 2011/12/31 08:08:16, jar wrote: > http://codereview.chromium.org/9056001/diff/1/base/metrics/stats_table_unittest.cc > File base/metrics/stats_table_unittest.cc (right): ...
8 years, 11 months ago (2011-12-31 15:47:46 UTC) #3
jar (doing other things)
lgtm
8 years, 11 months ago (2011-12-31 17:24:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedvessenes@gmail.com/9056001/1003
8 years, 11 months ago (2011-12-31 17:42:17 UTC) #5
commit-bot: I haz the power
8 years, 11 months ago (2011-12-31 19:16:39 UTC) #6
Change committed as 116064

Powered by Google App Engine
This is Rietveld 408576698