Issue 9055: Build database files on the Mac (r4486)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9055: Build database files on the Mac (r4486) (Closed)

Created:
12 years, 1 month ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Build database files on the Mac (r4486). Sets HEADER_SEARCH_PATHS and adds needed files in third_party/WebKit/WebCore/platform/sql and third_party/WebKit/WebCore/storage to webkit.xcodeproj. Makes TestShell.xcodeproj depend on libsqlite. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4494

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+271 lines, -44 lines)			Patch
M	build/all.xcodeproj/project.pbxproj	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View	10 chunks	+43 lines, -0 lines	0 comments	Download
M	webkit/webkit.xcodeproj/project.pbxproj	View	33 chunks	+227 lines, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

TBR due to build break. The files we discussed in third_party/WebKit/WebCore/storage have been excluded from ...

12 years, 1 month ago (2008-11-03 21:43:40 UTC) #1

Aaron Boodman

12 years, 1 month ago (2008-11-03 21:46:00 UTC) #2

On 2008/11/03 21:43:40, Mark Mentovai wrote:
> TBR due to build break.
> 
> The files we discussed in third_party/WebKit/WebCore/storage have been
excluded
> from the build; they show up in the patch only because file refs have been
> added, but we don't compile them.

lgtm

Expand Messages | Collapse Messages