[cros] Profile photo caption made multiline.

[cros] Profile photo caption made multiline.


BUG=chromium-os:23576
TEST=Manual: see bug description


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115896

[Ivan Korotkov, 2011-12-28 14:42:23]

PTAL

[Nikita (slow), 2011-12-28 14:49:42]

lgtm

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.css (left):

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.css:340: overflow: hidden;
How many lines could fit in there now? 2 or 3?

[Ivan Korotkov, 2011-12-28 15:31:56]

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.css (left):

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.css:340: overflow: hidden;
On 2011/12/28 14:49:42, Nikita Kostylev wrote:
> How many lines could fit in there now? 2 or 3?

2. It doesn't look neatly enough IMO, so I'd suggest still shortening the label.

[commit-bot: I haz the power, 2011-12-28 15:55:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ivankr@chromium.org/9049006/1

[commit-bot: I haz the power, 2011-12-28 17:18:38]

Change committed as 115896

[Nikita (slow), 2011-12-28 18:44:43]

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe.css (left):

http://codereview.chromium.org/9049006/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe.css:340: overflow: hidden;
On 2011/12/28 15:31:56, Ivan Korotkov wrote:
> On 2011/12/28 14:49:42, Nikita Kostylev wrote:
> > How many lines could fit in there now? 2 or 3?
> 
> 2. It doesn't look neatly enough IMO, so I'd suggest still shortening the
label.

Please mention that in message description. You could mention that in a way "Max
space for one line message if written in 'w' letters is X". Or a similar way to
provide some guideline how Language specialist could check that.