Allow plugins to participate in Chrome context menus.

Allow plugins to add rotate commands to Chrome context menus.
BUG=63249
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117297

[bbudge, 2011-12-27 19:31:07]

This isn't ready for review, but I'd like to get comments and feedback on the
approach I'm taking to this. The goal is to have plugin commands in Chrome
context menus, specifically for PDF so we can rotate the page. I think this
could be more generally useful in the future.

[jam, 2011-12-27 19:43:38]

thanks for working on this :)

i think for simplicity we can skip the fit commands for now, since we dont have
an intention of putting them in the right click menu as they already have an
icon.

http://codereview.chromium.org/9045007/diff/1/webkit/glue/context_menu.h
File webkit/glue/context_menu.h (right):

http://codereview.chromium.org/9045007/diff/1/webkit/glue/context_menu.h#newc...
webkit/glue/context_menu.h:90: // was invoked on.
do we really need to add this? can't we use custom_items below?

[bbudge, 2011-12-28 15:19:42]

I forgot to include the PPAPI interface that we'll need to make this approach
work. (There is also a small WebKit patch, to our port, to expose new
capabilities on WebPlugin.)

John's suggestion leads to another approach. We could add PPB_ContextMenu_Dev
and PPP_ContextMenu_Dev interfaces, so clients could register context menu items
and Chrome can call back into the plugin to execute the corresponding actions.
If that is preferable, I'll redo the patch.

http://codereview.chromium.org/9045007/diff/1/webkit/glue/context_menu.h
File webkit/glue/context_menu.h (right):

http://codereview.chromium.org/9045007/diff/1/webkit/glue/context_menu.h#newc...
webkit/glue/context_menu.h:90: // was invoked on.
Wouldn't that require that the plugin defines the menu items? I thought about
that approach but decided it was too much new PPAPI surface area. It would
require new PPB_ContextMenu and PPP_ContextMenuClient interfaces. If that would
be acceptable, I could do that. It is more powerful, and keeps most of the new
code in PPAPI and the plugin.
On 2011/12/27 19:43:39, John Abd-El-Malek wrote:
> do we really need to add this? can't we use custom_items below?

[bbudge, 2012-01-02 18:55:51]

John, I see now I can use localized resources in the renderer to create custom
menu items in the WebKit-glue area, to avoid having to add menu items to Chrome
itself. I'll modify the patch to do that and create custom menu items.

[bbudge, 2012-01-07 20:20:48]

John, I tried to use custom_items but it started getting complicated. It's
really designed for completely taking over the menu, as Flash does. There are
issues with how the items get merged with others, and also how to define the
command ids. They have to be put into the custom range that WebKit uses. It's
not pretty.

I think this approach is a much smaller change.

[bbudge, 2012-01-07 20:24:25]

Adding avi and/or brettw for chrome/browser/tab_contents.

[jam, 2012-01-08 23:12:02]

lgtm, thanks for doing this!

btw you don't need owners approval for chrome/browser/tab_contents since the
parent directories don't have an owners file, and chrome/browser/tab_contents
doesn't have set noparent

[commit-bot: I haz the power, 2012-01-11 18:55:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/9045007/26001

[commit-bot: I haz the power, 2012-01-11 18:55:24]

Can't apply patch for file
chrome/browser/tab_contents/render_view_context_menu.cc.
While running patch -p0 --forward --force;
patching file chrome/browser/tab_contents/render_view_context_menu.cc
Hunk #1 FAILED at 1.
Hunk #4 succeeded at 815 (offset 21 lines).
Hunk #5 succeeded at 1197 (offset 21 lines).
Hunk #6 succeeded at 1562 (offset 21 lines).
Hunk #7 succeeded at 1932 (offset 21 lines).
1 out of 7 hunks FAILED -- saving rejects to file
chrome/browser/tab_contents/render_view_context_menu.cc.rej

[commit-bot: I haz the power, 2012-01-11 20:20:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/9045007/34002

[commit-bot: I haz the power, 2012-01-11 21:40:39]

Change committed as 117297