Issue 9045: The base unittests were succeeding for the isolated...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9045: The base unittests were succeeding for the isolated... (Closed)

Created:
12 years, 1 month ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
jar (doing other things)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The base unittests were succeeding for the isolated tests, but failed when all tests were run because some tests run without a message loop. The observer_list_threadsafe allowed AddObserver to run with null message loops. But, if you call Notify after doing so, then the notify call would attempt to use the registered "null" ptr to a message loop. This crashed, of course. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4459

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	base/observer_list_threadsafe.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jar (doing other things)

12 years, 1 month ago (2008-11-03 19:44:24 UTC) #2

LGTM  with a TODO(mbeleshe) to clean up interaction so that contract violations
(not having a message loop) will be identified in chrome (even if the unit tests
can, when they need to, get away without).

Expand Messages | Collapse Messages