Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: src/handles.cc

Issue 9038: Create an abstraction for the string type flags so that they can be cached.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/handles.cc
===================================================================
--- src/handles.cc (revision 654)
+++ src/handles.cc (working copy)
@@ -117,9 +117,10 @@
void FlattenString(Handle<String> string) {
- if (string->IsFlat()) return;
- CALL_HEAP_FUNCTION_VOID(string->Flatten());
- ASSERT(string->IsFlat());
+ StringShape shape(*string);
+ if (string->IsFlat(shape)) return;
+ CALL_HEAP_FUNCTION_VOID(string->Flatten(shape));
+ ASSERT(string->IsFlat(StringShape(*string)));
}
@@ -216,7 +217,8 @@
Handle<String> SubString(Handle<String> str, int start, int end) {
- CALL_HEAP_FUNCTION(str->Slice(start, end), String);
+ StringShape shape(*str);
+ CALL_HEAP_FUNCTION(str->Slice(shape, start, end), String);
}

Powered by Google App Engine
This is Rietveld 408576698