Create an abstraction for the string type flags so that they can be cached....

src/objects-debug.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 447 matching lines @@
 
 void JSValue::JSValueVerify() {
   Object* v = value();
   if (v->IsHeapObject()) {
     VerifyHeapPointer(v);
   }
 }
 
 
 void String::StringPrint() {
-  if (IsSymbol()) {
+  StringShape shape(this);
+  if (shape.IsSymbol()) {
     PrintF("#");
-  } else if (IsConsString()) {
+  } else if (shape.IsCons()) {
     PrintF("c\"");
   } else {
     PrintF("\"");
   }
 
   for (int i = 0; i < length(); i++) {
-    PrintF("%c", Get(i));
+    PrintF("%c", Get(shape, i));
   }
 
-  if (!IsSymbol()) PrintF("\"");
+  if (!shape.IsSymbol()) PrintF("\"");
 }
 
 
 void String::StringVerify() {
   CHECK(IsString());
   CHECK(length() >= 0 && length() <= Smi::kMaxValue);
   if (IsSymbol()) {
     CHECK(!Heap::InNewSpace(this));
   }
 }
@@ skipping 557 matching lines @@
     }
     current = hash;
   }
   return true;
 }
 
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal