Add client/tests/client web tests to the test.dart test script.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_suite");
 
 #import("status_file_parser.dart");
 #import("test_runner.dart");
 #import("multitest.dart");
 
@@ skipping 226 matching lines @@
           filename.substring(middle + 1, filename.length - 5);
     } else {
       // This case is hit by the dartc client compilation
       // tests. These tests are pretty broken compared to the
       // rest. They use the .dart suffix in the status files. They
       // find tests in weird ways (testing that they contain "#").
       // They need to be redone.
       start = filename.indexOf(directoryPath);
       testName = filename.substring(start + directoryPath.length + 1,
                                     filename.length);
+      if (configuration['component'] != 'dartc') {
+        if (testName.endsWith('.dart')) {
+          testName = testName.substring(0, testName.length - 5);
+        }
+      }
     }
     Set<String> expectations = testExpectations.expectations(testName);
     if (configuration["report"]) {
       // Tests with multiple VMOptions are counted more than once.
       for (var dummy in optionsFromFile["vmOptions"]) {
         SummaryReport.add(expectations);
       }
     }
     if (expectations.contains(SKIP)) return;
 
@@ skipping 77 matching lines @@
                           bool isNegative) {
     if (optionsFromFile['isMultitest']) return;
     bool isWebTest = optionsFromFile['containsDomImport'];
     bool isLibraryDefinition = optionsFromFile['isLibraryDefinition'];
     if (!isLibraryDefinition && optionsFromFile['containsSourceOrImport']) {
       print('Warning for $filename: Browser tests require #library ' +
             'in any file that uses #import or #source');
     }      
 
     String tempDirTemplate = '${TestUtils.buildDir(configuration)}/tmp';
-    if (isWebTest) tempDirTemplate = 'client/' + tempDirTemplate;
+    // if (isWebTest) tempDirTemplate = 'client/' + tempDirTemplate;

[ahe, 2012/01/02 10:42:23]

Delete this line?

[Bill Hesse, 2012/01/02 12:50:42]

Yes.  But the real change should be to refactor, and merge the Dartium case
(which here generates temporary directories) with the Chromium and Frogium case,
which generate subdirectories of generated_tests.

On 2012/01/02 10:42:23, ahe wrote:

     Directory tempDir = new Directory(tempDirTemplate);
     // TODO(whesse): When implementing client web tests,
     // create directory in the client case, if it doesn't exist.
     tempDir.createTempSync();
 
     String dartTestFilename = new File(filename).fullPathSync();
-    String dartWrapperFilename = '${tempDir.path}/test.dart';
-    if (!isWebTest) {
+    String dartWrapperFilename;
+    String scriptPath;
+    if (isWebTest) {
+      scriptPath = 'file://$dartTestFilename';

[ahe, 2012/01/02 10:42:23]

This doesn't work on Windows. Please add an abstraction to compute this and
consider adding it to the File interface.

[Bill Hesse, 2012/01/02 12:50:42]

The Path and URI libraries are the next thing I will be working on this quarter.
 This issue would be solved by using them.  I will put in a fix, but not add it
to the file interface.

[ahe, 2012/01/02 13:00:59]

SGTM, I guess a TODO would serve the same purpose.

+    } else {
+      dartWrapperFilename = '${tempDir.path}/test.dart';
+      scriptPath = '../../../$dartWrapperFilename';
       // test.dart will import the dart test directly, if it is a library,
       // or indirectly through test_as_library.dart, if it is not.
       String dartLibraryFilename;
       if (isLibraryDefinition) {
         dartLibraryFilename = dartTestFilename;
       } else {
         dartLibraryFilename = 'test_as_library.dart';
         File file = new File('${tempDir.path}/$dartLibraryFilename');
         RandomAccessFile dartLibrary = file.openSync(writable: true);
         dartLibrary.writeStringSync(WrapDartTestInLibrary(dartTestFilename));
         dartLibrary.closeSync();
       }
-
+        

[ahe, 2012/01/02 10:42:23]

Trailing whitespace.

       File file = new File(dartWrapperFilename);
       RandomAccessFile dartWrapper = file.openSync(writable: true);
       dartWrapper.writeStringSync(DartTestWrapper(
           'dart:dom',
           '../../../tests/isolate/src/TestFramework.dart',
           dartLibraryFilename));
       dartWrapper.closeSync();
-    } else {
-      return;  // TODO(whesse): Implement client web tests on dartium.
     }
     // Create the HTML file for the test.
+    // NOTE: This must be 3 directories below the dart root, due to test
+    // client/samples/dartcombat containing a relative path to its .css file.
     File htmlTestBase = new File('${tempDir.path}/${getHtmlName(filename)}');
     RandomAccessFile htmlTest = htmlTestBase.openSync(writable: true);
     htmlTest.writeStringSync(GetHtmlContents(
         filename,
         '../../../client/testing/unittest/test_controller.js',
         scriptType,
-        '../../../$dartWrapperFilename'));
+        scriptPath));
     htmlTest.closeSync();
 
     for (var vmOptions in optionsFromFile["vmOptions"]) {
-      var drtFlags = ['-no-timeout'];
+      var drtFlags = ['--no-timeout'];
       var dartFlags = ['--enable_asserts', '--enable_type_checks'];
       dartFlags.addAll(vmOptions);
       drtFlags.add('--dart-flags=${Strings.join(dartFlags, " ")}');
       var args = drtFlags;
       args.add(htmlTestBase.fullPathSync());
 
       // Create BrowserTestCase and queue it.
       var testCase = new BrowserTestCase(
           testName,
           null,
@@ skipping 32 matching lines @@
     String testRelativeDirFlattened;
 
     int start = testRelativePath.lastIndexOf('src' + pathSeparator);
     if (start != -1) {
       Expect.isTrue(testRelativePath.endsWith('.dart'));
       testNameBase =
           testRelativePath.substring(start + 4, testRelativePath.length - 5);
       testRelativeDir = testRelativePath.substring(0, start - 1);
       testRelativeDirFlattened = testRelativeDir.replaceAll(pathSeparator, '_');
     } else {
-      Expect.fail('Web tests not imlemented yet');
+      Expect.isTrue(testRelativePath.endsWith('_tests.dart'));
+      start = testRelativePath.lastIndexOf(pathSeparator);
+      testNameBase =
+          testRelativePath.substring(start + 1, testRelativePath.length - 11);
     }
 
     if (!new Directory('$dartDir/$buildDir/generated_tests').existsSync()) {
       new Directory('$dartDir/$buildDir/generated_tests').createSync();
     }
     if (!new Directory(outputDirBase).existsSync()) {
       new Directory(outputDirBase).createSync();
     }
     Directory tempDir = new Directory(
         '$outputDirBase/${testRelativeDirFlattened}_$testNameBase');
     if (!tempDir.existsSync()) {
       tempDir.createSync();
     }
 
     String dartWrapperFilename = '${tempDir.path}/test.dart';
     String compiledDartWrapperFilename = '${tempDir.path}/test.js';
     String domLibraryImport = 'dart:dom';
     if (configuration['component'] == 'chromium') {
       domLibraryImport =
           '$dartDir/client/testing/unittest/dom_for_unittest.dart';
     }
 
+    File htmlTestBase;
     if (!isWebTest) {
       // test.dart will import the dart test directly, if it is a library,
       // or indirectly through test_as_library.dart, if it is not.
       String dartLibraryFilename;
       if (isLibraryDefinition) {
         dartLibraryFilename = testPath;
       } else {
         dartLibraryFilename = 'test_as_library.dart';
         File file = new File('${tempDir.path}/$dartLibraryFilename');
         RandomAccessFile dartLibrary = file.openSync(writable: true);
         dartLibrary.writeStringSync(WrapDartTestInLibrary(testPath));
         dartLibrary.closeSync();
       }  
       
       File file = new File(dartWrapperFilename);
       RandomAccessFile dartWrapper = file.openSync(writable: true);
       dartWrapper.writeStringSync(DartTestWrapper(
           domLibraryImport,
           '$dartDir/tests/isolate/src/TestFramework.dart',
           dartLibraryFilename));
       dartWrapper.closeSync();
+      htmlTestBase = new File('${tempDir.path}/${getHtmlName(filename)}');
     } else {
-      return;  // TODO(whesse): Implement client web tests on dartium.
+      dartWrapperFilename = testPath;
+      // TODO(whesse): Once test.py is retired, adjust the relative path in
+      // the client/samples/dartcombat test to its css file, remove the
+      // "../../" from this path, and move this out of the isWebTest guard.
+      htmlTestBase = new File('${tempDir.path}/../../${getHtmlName(filename)}');
+      // return;  // TODO(whesse): Implement client web tests on dartium.

[ahe, 2012/01/02 10:42:23]

Remove this line.

     }
     // Create the HTML file for the test.
-    File htmlTestBase = new File('${tempDir.path}/${getHtmlName(filename)}');
     RandomAccessFile htmlTest = htmlTestBase.openSync(writable: true);
     htmlTest.writeStringSync(GetHtmlContents(
         filename,
         '$dartDir/client/testing/unittest/test_controller.js',
         scriptType,
         compiledDartWrapperFilename));
     htmlTest.closeSync();
 
     for (var vmOptions in optionsFromFile["vmOptions"]) {
       List<String> compilerArgs;
@@ skipping 62 matching lines @@
         return tempDir.path + 'test.js';
       default:
         Expect.fail('Unimplemented component scriptType');
         return null;
     }
   }
 
   String getHtmlName(String filename) {
     switch (configuration['component']) {
       case 'dartium':
         return filename.replaceAll(pathSeparator, '_') + 'dartium.html';

[ahe, 2012/01/02 10:42:23]

This doesn't work on Windows. Consider that a windows file path may contain
forward slashes as well as backslashes.

[Bill Hesse, 2012/01/02 12:50:42]

Aaarrrrgh.

[Bill Hesse, 2012/01/03 15:01:35]

Now all arguments to this have only forward slashes.

On 2012/01/02 10:42:23, ahe wrote:

       case 'chromium':
+        return filename.replaceAll(pathSeparator, '_') + 'chromium.html';

[ahe, 2012/01/02 10:42:23]

Ditto.

       case 'frogium':
-        return 'test.html';
+        return filename.replaceAll(pathSeparator, '_') + 'frogium.html';

[ahe, 2012/01/02 10:42:23]

Ditto.

       default:
         Expect.fail('Unimplemented component scriptType');
         return null;
     }
   }
 
   String get dumpRenderTreeFilename() {
     if (new Platform().operatingSystem() == 'macos') {
       return 'client/tests/drt/DumpRenderTree.app/Contents/' +
           'MacOS/DumpRenderTree';
@@ skipping 322 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout\
 """;
     print(report);
   }
 }