Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/sync/sessions/sync_session.h

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sessions/status_controller.cc ('k') | chrome/browser/sync/sessions/sync_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sessions/sync_session.h
diff --git a/chrome/browser/sync/sessions/sync_session.h b/chrome/browser/sync/sessions/sync_session.h
index abed10eac7fee2729f73822592e96fcf2acd02f9..8f9148f97abe885e5327c8dcbc6e490fce933319 100644
--- a/chrome/browser/sync/sessions/sync_session.h
+++ b/chrome/browser/sync/sessions/sync_session.h
@@ -112,6 +112,22 @@ class SyncSession {
// engine again.
bool HasMoreToSync() const;
+ // Returns true if this session experienced an error that could possibly go
+ // away on its own. This suggests a good course of action would be to try
+ // again later.
+ //
+ // Returns false if the session has not been used in a call to SyncShare, or
+ // if no error was detected, or if at all recorded errors were non-transient.
+ bool ExperiencedTransientError() const;
+
+ // Returns true if this session completed without experiencing any sort of
+ // errors.
+ //
+ // Returns false if SyncShare has not been called on this session yet, or
+ // if ResetTransientState() has been called on this session since the last
+ // call to SyncShare.
+ bool Succeeded() const;
+
// Collects all state pertaining to how and why |s| originated and unions it
// with corresponding state in |this|, leaving |s| unchanged. Allows |this|
// to take on the responsibilities |s| had (e.g. certain data types) in the
« no previous file with comments | « chrome/browser/sync/sessions/status_controller.cc ('k') | chrome/browser/sync/sessions/sync_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698