chrome/browser/sync/engine/process_commit_response_command.h - Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/process_commit_response_command.h

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/engine/process_commit_response_command.h

diff --git a/chrome/browser/sync/engine/process_commit_response_command.h b/chrome/browser/sync/engine/process_commit_response_command.h

index bac2a31770e55e7dbe5badc2517c3c8d1c7c7920..23bf56dbd1df0cc3e37176e013d0e1e74a48c56a 100644

--- a/chrome/browser/sync/engine/process_commit_response_command.h

+++ b/chrome/browser/sync/engine/process_commit_response_command.h

@@ -32,9 +32,9 @@ class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {

// ModelChangingSyncerCommand implementation.

virtual std::set<ModelSafeGroup> GetGroupsToChange(

const sessions::SyncSession& session) const OVERRIDE;

- virtual bool ModelNeutralExecuteImpl(

+ virtual SyncerError ModelNeutralExecuteImpl(

sessions::SyncSession* session) OVERRIDE;

- virtual void ModelChangingExecuteImpl(

+ virtual SyncerError ModelChangingExecuteImpl(

sessions::SyncSession* session) OVERRIDE;

private:

@@ -47,7 +47,7 @@ class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {

std::set<syncable::Id>* deleted_folders);

// Actually does the work of execute.

- void ProcessCommitResponse(sessions::SyncSession* session);

+ SyncerError ProcessCommitResponse(sessions::SyncSession* session);

void ProcessSuccessfulCommitResponse(

const sync_pb::SyncEntity& committed_entry,