Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/sync/glue/browser_thread_model_worker.h

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 5 #ifndef CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
6 #define CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 6 #define CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/callback_forward.h" 10 #include "base/callback_forward.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "chrome/browser/sync/engine/model_safe_worker.h" 12 #include "chrome/browser/sync/engine/model_safe_worker.h"
13 #include "chrome/browser/sync/util/unrecoverable_error_info.h" 13 #include "chrome/browser/sync/engine/syncer_error.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 15
16 namespace base { 16 namespace base {
17 class WaitableEvent; 17 class WaitableEvent;
18 } 18 }
19 19
20 namespace browser_sync { 20 namespace browser_sync {
21 21
22 // A ModelSafeWorker for models that accept requests from the syncapi that need 22 // A ModelSafeWorker for models that accept requests from the syncapi that need
23 // to be fulfilled on a browser thread, for example autofill on the DB thread. 23 // to be fulfilled on a browser thread, for example autofill on the DB thread.
24 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc). 24 // TODO(sync): Try to generalize other ModelWorkers (e.g. history, etc).
25 class BrowserThreadModelWorker : public ModelSafeWorker { 25 class BrowserThreadModelWorker : public ModelSafeWorker {
26 public: 26 public:
27 BrowserThreadModelWorker(content::BrowserThread::ID thread, 27 BrowserThreadModelWorker(content::BrowserThread::ID thread,
28 ModelSafeGroup group); 28 ModelSafeGroup group);
29 virtual ~BrowserThreadModelWorker(); 29 virtual ~BrowserThreadModelWorker();
30 30
31 // ModelSafeWorker implementation. Called on the sync thread. 31 // ModelSafeWorker implementation. Called on the sync thread.
32 virtual UnrecoverableErrorInfo DoWorkAndWaitUntilDone( 32 virtual SyncerError DoWorkAndWaitUntilDone(
33 const WorkCallback& work) OVERRIDE; 33 const WorkCallback& work) OVERRIDE;
34 virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE; 34 virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE;
35 35
36 protected: 36 protected:
37 // Marked pure virtual so subclasses have to override, but there is 37 // Marked pure virtual so subclasses have to override, but there is
38 // an implementation that subclasses should use. This is so that 38 // an implementation that subclasses should use. This is so that
39 // (subclass)::CallDoWorkAndSignalTask shows up in callstacks. 39 // (subclass)::CallDoWorkAndSignalTask shows up in callstacks.
40 virtual void CallDoWorkAndSignalTask( 40 virtual void CallDoWorkAndSignalTask(
41 const WorkCallback& work, 41 const WorkCallback& work,
42 base::WaitableEvent* done, 42 base::WaitableEvent* done,
43 UnrecoverableErrorInfo* error_info) = 0; 43 SyncerError* error) = 0;
44 44
45 private: 45 private:
46 content::BrowserThread::ID thread_; 46 content::BrowserThread::ID thread_;
47 ModelSafeGroup group_; 47 ModelSafeGroup group_;
48 48
49 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker); 49 DISALLOW_COPY_AND_ASSIGN(BrowserThreadModelWorker);
50 }; 50 };
51 51
52 // Subclass BrowserThreadModelWorker so that we can distinguish them 52 // Subclass BrowserThreadModelWorker so that we can distinguish them
53 // from stack traces alone. 53 // from stack traces alone.
54 54
55 class DatabaseModelWorker : public BrowserThreadModelWorker { 55 class DatabaseModelWorker : public BrowserThreadModelWorker {
56 public: 56 public:
57 DatabaseModelWorker(); 57 DatabaseModelWorker();
58 virtual ~DatabaseModelWorker(); 58 virtual ~DatabaseModelWorker();
59 59
60 protected: 60 protected:
61 virtual void CallDoWorkAndSignalTask( 61 virtual void CallDoWorkAndSignalTask(
62 const WorkCallback& work, 62 const WorkCallback& work,
63 base::WaitableEvent* done, 63 base::WaitableEvent* done,
64 UnrecoverableErrorInfo* error_info) OVERRIDE; 64 SyncerError* error) OVERRIDE;
65 }; 65 };
66 66
67 class FileModelWorker : public BrowserThreadModelWorker { 67 class FileModelWorker : public BrowserThreadModelWorker {
68 public: 68 public:
69 FileModelWorker(); 69 FileModelWorker();
70 virtual ~FileModelWorker(); 70 virtual ~FileModelWorker();
71 71
72 protected: 72 protected:
73 virtual void CallDoWorkAndSignalTask( 73 virtual void CallDoWorkAndSignalTask(
74 const WorkCallback& work, 74 const WorkCallback& work,
75 base::WaitableEvent* done, 75 base::WaitableEvent* done,
76 UnrecoverableErrorInfo* error_info) OVERRIDE; 76 SyncerError* error) OVERRIDE;
77 }; 77 };
78 78
79 } // namespace browser_sync 79 } // namespace browser_sync
80 80
81 #endif // CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_ 81 #endif // CHROME_BROWSER_SYNC_GLUE_BROWSER_THREAD_MODEL_WORKER_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/verify_updates_command.cc ('k') | chrome/browser/sync/glue/browser_thread_model_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698