chrome/browser/sync/engine/process_updates_command.h - Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.h

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_	5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_

6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_	6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_

7 #pragma once	7 #pragma once

8	8

9 #include "base/compiler_specific.h"	9 #include "base/compiler_specific.h"

10 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"	10 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"

(...skipping 20 matching lines...) Expand all Loading...
31 // TODO(tim): This should not be ModelChanging (bug 36592).	31 // TODO(tim): This should not be ModelChanging (bug 36592).

32 class ProcessUpdatesCommand : public ModelChangingSyncerCommand {	32 class ProcessUpdatesCommand : public ModelChangingSyncerCommand {

33 public:	33 public:

34 ProcessUpdatesCommand();	34 ProcessUpdatesCommand();

35 virtual ~ProcessUpdatesCommand();	35 virtual ~ProcessUpdatesCommand();

36	36

37 protected:	37 protected:

38 // ModelChangingSyncerCommand implementation.	38 // ModelChangingSyncerCommand implementation.

39 virtual std::set<ModelSafeGroup> GetGroupsToChange(	39 virtual std::set<ModelSafeGroup> GetGroupsToChange(

40 const sessions::SyncSession& session) const OVERRIDE;	40 const sessions::SyncSession& session) const OVERRIDE;

41 virtual void ModelChangingExecuteImpl(	41 virtual SyncerError ModelChangingExecuteImpl(

42 sessions::SyncSession* session) OVERRIDE;	42 sessions::SyncSession* session) OVERRIDE;

43	43

44 private:	44 private:

45 ServerUpdateProcessingResult ProcessUpdate(	45 ServerUpdateProcessingResult ProcessUpdate(

46 const syncable::ScopedDirLookup& dir,	46 const syncable::ScopedDirLookup& dir,

47 const sync_pb::SyncEntity& proto_update,	47 const sync_pb::SyncEntity& proto_update,

48 syncable::WriteTransaction* const trans);	48 syncable::WriteTransaction* const trans);

49 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand);	49 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand);

50 };	50 };

51	51

52 } // namespace browser_sync	52 } // namespace browser_sync

53	53

54 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_	54 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_

OLD	NEW