Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/sync/engine/build_commit_command.h

Issue 9036003: Avoid useless SYNC_CYCLE_CONTINUATION sync cycle (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "chrome/browser/sync/engine/syncer_command.h" 11 #include "chrome/browser/sync/engine/syncer_command.h"
12 #include "chrome/browser/sync/engine/syncproto.h" 12 #include "chrome/browser/sync/engine/syncproto.h"
13 #include "chrome/browser/sync/syncable/syncable.h" 13 #include "chrome/browser/sync/syncable/syncable.h"
14 14
15 namespace browser_sync { 15 namespace browser_sync {
16 16
17 class BuildCommitCommand : public SyncerCommand { 17 class BuildCommitCommand : public SyncerCommand {
18 public: 18 public:
19 BuildCommitCommand(); 19 BuildCommitCommand();
20 virtual ~BuildCommitCommand(); 20 virtual ~BuildCommitCommand();
21 21
22 // SyncerCommand implementation. 22 // SyncerCommand implementation.
23 virtual void ExecuteImpl(sessions::SyncSession* session) OVERRIDE; 23 virtual SyncerError ExecuteImpl(sessions::SyncSession* session) OVERRIDE;
24 24
25 private: 25 private:
26 FRIEND_TEST_ALL_PREFIXES(BuildCommitCommandTest, InterpolatePosition); 26 FRIEND_TEST_ALL_PREFIXES(BuildCommitCommandTest, InterpolatePosition);
27 27
28 // Functions returning constants controlling range of values. 28 // Functions returning constants controlling range of values.
29 static int64 GetFirstPosition(); 29 static int64 GetFirstPosition();
30 static int64 GetLastPosition(); 30 static int64 GetLastPosition();
31 static int64 GetGap(); 31 static int64 GetGap();
32 32
33 void AddExtensionsActivityToMessage(sessions::SyncSession* session, 33 void AddExtensionsActivityToMessage(sessions::SyncSession* session,
34 CommitMessage* message); 34 CommitMessage* message);
35 // Helper for computing position. Find the numeric position value 35 // Helper for computing position. Find the numeric position value
36 // of the closest already-synced entry. |direction| must be one of 36 // of the closest already-synced entry. |direction| must be one of
37 // NEXT_ID or PREV_ID; this parameter controls the search direction. 37 // NEXT_ID or PREV_ID; this parameter controls the search direction.
38 // For an open range (no predecessor or successor), the return 38 // For an open range (no predecessor or successor), the return
39 // value will be kFirstPosition or kLastPosition. 39 // value will be kFirstPosition or kLastPosition.
40 int64 FindAnchorPosition(syncable::IdField direction, 40 int64 FindAnchorPosition(syncable::IdField direction,
41 const syncable::Entry& entry); 41 const syncable::Entry& entry);
42 // Given two values of the type returned by FindAnchorPosition, 42 // Given two values of the type returned by FindAnchorPosition,
43 // compute a third value in between the two ranges. 43 // compute a third value in between the two ranges.
44 int64 InterpolatePosition(int64 lo, int64 hi); 44 int64 InterpolatePosition(int64 lo, int64 hi);
45 45
46 DISALLOW_COPY_AND_ASSIGN(BuildCommitCommand); 46 DISALLOW_COPY_AND_ASSIGN(BuildCommitCommand);
47 }; 47 };
48 48
49 } // namespace browser_sync 49 } // namespace browser_sync
50 50
51 #endif // CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_ 51 #endif // CHROME_BROWSER_SYNC_ENGINE_BUILD_COMMIT_COMMAND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698