Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: frog/tests/leg/src/SsaPhiEliminatorTest.dart

Issue 9035008: Do not generate at use site loop phis. It requires live analysis that we currently don't implement. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/leg/ssa/phi_eliminator.dart ('k') | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/leg/src/SsaPhiEliminatorTest.dart
===================================================================
--- frog/tests/leg/src/SsaPhiEliminatorTest.dart (revision 2800)
+++ frog/tests/leg/src/SsaPhiEliminatorTest.dart (working copy)
@@ -54,6 +54,8 @@
}
""";
+String anyIdentifier = "[a-zA-Z][a-zA-Z0-9]*";
+
main() {
String generated = compile(TEST_ONE, 'foo');
RegExp regexp = const RegExp("a = 2");
@@ -66,15 +68,12 @@
Expect.isTrue(regexp.hasMatch(generated));
generated = compile(TEST_TWO, 'main');
- regexp = const RegExp("t = \\(t +");
+ regexp = new RegExp("t = \\($anyIdentifier +");
Expect.isTrue(regexp.hasMatch(generated));
- regexp = const RegExp("i = \\(i +");
+ regexp = new RegExp("i = \\($anyIdentifier +");
Expect.isTrue(regexp.hasMatch(generated));
- regexp = const RegExp("print\\(t\\)");
- Expect.isTrue(regexp.hasMatch(generated));
-
generated = compile(TEST_THREE, 'foo');
// Check that we don't have 'val = val'.
« no previous file with comments | « frog/leg/ssa/phi_eliminator.dart ('k') | frog/tests/leg/src/TypeInferenceTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698