Issue 9034017: Move the gyp file to ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9034017: Move the gyp file to ash. (Closed)

Created:
8 years, 12 months ago by Ben Goodger (Google)

Modified:
8 years, 12 months ago

Reviewers:
sky

CC:
chromium-reviews, dhollowa+watch_chromium.org, ben+watch_chromium.org, sadrul, Nirnimesh, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move the gyp file to ash. http://crbug.com/108457 TEST=none TBR=sky Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115744

Patch Set 3 : '' #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+214 lines, -475 lines)			Patch
M	WATCHLISTS	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ash/ash.gyp	View	1 2	2 chunks	+209 lines, -209 lines	0 comments	Download
M	build/all.gyp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
D	ui/aura_shell/aura_shell.gyp	View		1 chunk	+0 lines, -261 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/9034017/diff/1/ash/ash.gyp File ash/ash.gyp (right): http://codereview.chromium.org/9034017/diff/1/ash/ash.gyp#newcode35 ash/ash.gyp:35: # All .cc, .h under views, except unittests nit: ...

8 years, 12 months ago (2011-12-24 00:03:08 UTC) #1

Ben Goodger (Google)

8 years, 12 months ago (2011-12-24 00:12:45 UTC) #2

tfarina

8 years, 12 months ago (2011-12-24 00:14:42 UTC) #3

http://codereview.chromium.org/9034017/diff/1006/ash/ash.gyp
File ash/ash.gyp (right):

http://codereview.chromium.org/9034017/diff/1006/ash/ash.gyp#newcode37
ash/ash.gyp:37: 'ash_switches.h',
nit: so this goes after app_list ;)

Expand Messages | Collapse Messages

Issue 9034017: Move the gyp file to ash. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages