Issue 9030036: Fix bug 62037: Task manager tooltips appear behind task manager if 'Always on Top' is checked.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9030036: Fix bug 62037: Task manager tooltips appear behind task manager if 'Always on Top' is checked. (Closed)

Created:
8 years, 11 months ago by jianli

Modified:
8 years, 10 months ago

Reviewers:
cbentzel, Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix bug 62037: Task manager tooltips appear behind task manager if 'Always on Top' is checked. The fix is to ensure the tooltip window is created with WS_EX_TOPMOST style. BUG=62037 TEST=Manual test by launching task manager or panel and verifying tooltips appear in front. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=116551

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	ui/views/widget/tooltip_manager_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/9030036/1

8 years, 11 months ago (2012-01-05 18:04:42 UTC) #3

cbentzel

8 years, 10 months ago (2012-02-07 18:58:46 UTC) #5

It looks like this broke the z-ordering when the file chooser is brought up
while doing a "Save Image As" context menu. I was able to bisect down to this CL
- and in particular the ALWAYS_ON_TOP in TooltipManagerWin::Init

It looks like the context menu is treated as a tooltip, and this causes it to
layer on top of the other dialog.

Expand Messages | Collapse Messages