Move InMemoryURLIndex Caching Operations to FILE Thread

chrome/browser/history/in_memory_url_index_types.h

Index: chrome/browser/history/in_memory_url_index_types.h
===================================================================
--- chrome/browser/history/in_memory_url_index_types.h	(revision 125451)
+++ chrome/browser/history/in_memory_url_index_types.h	(working copy)
@@ -10,6 +10,7 @@
 #include <set>
 #include <vector>
 
+#include "base/memory/ref_counted.h"
 #include "base/string16.h"
 #include "chrome/browser/history/history_types.h"
 #include "chrome/browser/autocomplete/history_provider_util.h"
@@ -74,6 +75,29 @@
 };
 typedef std::vector<ScoredHistoryMatch> ScoredHistoryMatches;
 
+// RefCountedBool --------------------------------------------------------------
+
+// An implementation of RefCountedMemory that manages a bool that we use for
+// passing around success when saving our cache.
+class RefCountedBool : public RefCountedMemory {

[brettw, 2012/03/12 04:37:40]

IT wasn't the intent for all random types to go in this file, especially since
this is an internal type used by only one function.

I think this should be a member of the class that needs it. You can probably
forward declare it to keep everything but the forward declare in the .cc file.

Don't derive from RefCountedMemory, that's for a bag of bytes. Just derive from
RefCounted. If you're passing between threads (I think you are), you need to use
RefCountedThreadSafe

[mrossetti, 2012/03/13 22:25:46]

This class is used to exchange status between the InMemoryURLIndex class and the
URLIndexPrivateData class so I moved it into in_memory_url_index.h but not as a
member of the InMemoryURLIndex class since subclasses cannot be forward
declared.
Done.

+ public:
+  explicit RefCountedBool(bool value) : bool_(value) {}
+
+  virtual const unsigned char* front() const OVERRIDE;

[brettw, 2012/03/12 04:37:40]

Delete these.

[mrossetti, 2012/03/13 22:25:46]

Done.

+  virtual size_t size() const OVERRIDE;
+
+  bool value() { return bool_; }

[brettw, 2012/03/12 04:37:40]

This should be const.

[mrossetti, 2012/03/13 22:25:46]

Done.

+  void set_value(bool value) { bool_ = value; }
+
+ private:
+  friend class base::RefCountedThreadSafe<RefCountedBool>;
+  virtual ~RefCountedBool();
+
+  bool bool_;

[brettw, 2012/03/12 04:37:40]

This should be called "value_" to match the getter & setter

+
+  DISALLOW_COPY_AND_ASSIGN(RefCountedBool);
+};
+
 // Convenience Types -----------------------------------------------------------
 
 typedef std::vector<string16> String16Vector;